don't crash when there is no data #7208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arikfr
reviewed
Oct 29, 2024
Member
arikfr
left a comment
arikfr
left a comment
There was a problem hiding this comment.
Thank you for taking a stab at this! Could you add a test case for this?
Contributor
Author
|
Added a test, and I made sure it fail on master |
arikfr
approved these changes
Oct 31, 2024
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Jan 8, 2025
* don't crash when there is no data * Add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
In case there is no data, it doesn't crash, it just leaves the state as
UNKNOWN_STATEHow is this tested?
Related Tickets & Documents
This closes issue 7196
Mobile & Desktop Screenshots/Recordings (if there are UI changes)