Multi-org: format base path, not including protocol

[eradman]

What type of PR is this?

• Tests

Description

Other tests and local settings sometimes caused this test to fail.

How is this tested?

• Unit tests (pytest, jest)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.03%. Comparing base (d03a2c4) to head (3711d87).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7260      +/-   ##
==========================================
+ Coverage   64.01%   64.03%   +0.01%     
==========================================
  Files         163      163              
  Lines       13410    13410              
  Branches     1905     1905              
==========================================
+ Hits         8585     8587       +2     
+ Misses       4490     4489       -1     
+ Partials      335      334       -1     

see 1 file with indirect coverage changes

[eradman]

@yoshiokatsuneo if you have time, can you review this change? TestAlertRenderTemplate often fails in my dev environment because of settings in .env

[yoshiokatsuneo]

@eradman

Thank you for improving test environment.

I wonder whether it is good idea to change/reset settings on every tests, as it may make test code a bit messy...
How about using separate .env file for testing ( like .env_test ) ?

[yoshiokatsuneo]

Or, possibly, we can statically setup settings on the base TestCase class ?

[eradman]

How about using separate .env file for testing ( like .env_test ) ?

This is not a bad idea: there are probably other test cases that would fail with modified settings.

[eradman]

Instead of sanitizing the environment, I modified the utils.base_url() to prevent it from returning a hard-coded protocol (https://) when MULTI_ORG is enabled. As near as I can tell this is a bug, and not noticed by anyone.

[yoshiokatsuneo]

@eradman

Thank you ! Actually, it looks a bug, and you fixed it !

[eradman]

Thanks for the review again @yoshiokatsuneo!
MULTI_ORG has been an experimental feature, so most users are not likely to hit this code path.