feat(self-hosted): Publishes chartcuterie image for self hosted#199
Closed
hubertdeng123 wants to merge 12 commits into
Closed
feat(self-hosted): Publishes chartcuterie image for self hosted#199hubertdeng123 wants to merge 12 commits into
hubertdeng123 wants to merge 12 commits into
Conversation
Release notes says this is a migration to N-API, no code changes - https://github.com/Automattic/node-canvas/releases/tag/v3.0.0
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
|
"canvas" should be bumped, otherwise arm64 build will fail |
Member
Author
|
It makes sense to bump canvas in another PR then before adding this change |
Contributor
But if I were the one who made the PR, it'll fail anyway😭 |
Contributor
|
@hubertdeng123 can you rebase from the master branch? |
Member
|
Closed in favor of #218 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A copy of #196 since CI permissions are borked for contributors