fix(local): surface trace events inline in sentry local run#1105
Open
jared-outpost[bot] wants to merge 1 commit into
Open
fix(local): surface trace events inline in sentry local run#1105jared-outpost[bot] wants to merge 1 commit into
sentry local run#1105jared-outpost[bot] wants to merge 1 commit into
Conversation
When `sentry local run` auto-starts a background server, subscribe to the spotlight buffer so incoming envelopes are formatted and printed to the terminal — matching the behavior of `sentry local serve`. Previously the buffer silently collected envelopes without printing them, so users only saw a high-level confirmation message. Fixes #1099
Contributor
|
Contributor
Codecov Results 📊❌ Patch coverage is 70.00%. Project has 5015 uncovered lines. Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 81.19% 81.19% —%
==========================================
Files 383 383 —
Lines 26651 26661 +10
Branches 17354 17356 +2
==========================================
+ Hits 21638 21646 +8
- Misses 5013 5015 +2
- Partials 1798 1799 +1Generated by Codecov Action |
Contributor
Author
|
all CI checks passed (Build, Dependency Review, Secret Scan, Docs Preview, Warden, Semgrep) — marked ready for review. self-review found no issues; the change is a single-file fix that mirrors the existing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
sentry local runauto-starts a background server, it now subscribes to the spotlight buffer withformatEnvelopeLinesso envelope items (transactions, errors, logs) are printed to the terminal — matching the behavior ofsentry local serve.Previously the buffer was created but never subscribed to, so the only inline feedback was logger messages like "Background server listening on ...". Users had to run
sentry local servein a separate terminal to see event details.Testing
vitest run test/lib/formatters/local.test.ts test/lib/formatters/local.property.test.ts— 74/74)tsc --noEmitclean on changed file (pre-existing failures insdk.generated.jsandapi.ts-Halias are unrelated)biome checkcleanCloses #1099