Skip to content

fix(github): Guard against missing release #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 10, 2025
Merged

fix(github): Guard against missing release #567

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e86d77
fix: Guard against missing release
mydea Nov 22, 2024
ac2964b
only handle 404 errors
mydea Jan 10, 2025
69fcc6a
Update src/targets/github.ts
mydea Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions src/targets/github.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,10 +127,21 @@ export class GitHubTarget extends BaseTarget {
};
}

const { data: latestRelease } = await this.github.repos.getLatestRelease({
owner: this.githubConfig.owner,
repo: this.githubConfig.repo,
});
let latestRelease: { tag_name: string } | undefined;
try {
latestRelease = (
await this.github.repos.getLatestRelease({
owner: this.githubConfig.owner,
repo: this.githubConfig.repo,
})
).data;
} catch (error) {
// if the error is a 404 error, it means that no release exists yet
// all other errors should be rethrown
if (error.status !== 404) {
throw error;
}
}

const isLatest = isPreview
? false
Expand Down
Loading