feat: Install most recent Erlang from RabbitMQ packages #592
Conversation
This should fix the Elixir release issues: https://github.com/getsentry/publish/actions/runs/13697376301/job/38302799587#step:12:94
|
this does not seem like a good idea -- why not just upgrade instead of using some unofficial build |
|
@asottile-sentry would love to but the versions on the Debian repos are too old for our stuff. |
|
fwiw, I would rather just use a language version manager like https://github.com/asdf-vm/asdf-elixir to not have to maintain these on our side, especially if we're stuck with debian where a lot of stuff is just way out of date |
? on the link in the deleted comment I see 27.3 available which is the absolute latest |
|
@asottile-sentry I did check that before. The problem is, they do not publish the package listed there (hence our failures). We can try to download and install the I thin the RabbitMQ packages are used and relied on enough to make it here but if you disagree, I am okay to try downloading and installing the |
|
The hex.pm team maintains one the most widely-used Docker images for Elixir development. It supports Debian—here is an example of the latest Erlang/Elixir running on Debian. |
|
@whatyouhide the problem is we have a single container based on Is this the correct Dockerfile that builds the images you linked? Here they're building from source. I discussed having separate images per publishing tool, but I don't think anyone has time/motivation/investment justification to make such a large change to craft. The larger problem remains that maintaining this Dockerfile is a PITA and we break the release flow everytime someone attempts to do so. |
|
@sl0thentr0py yes that's the Dockerfile for Erlang, and then Elixir gets installed on top. You could also pin the Erlang version if it's just for releasing. You could also do asdf on the particular Elixir image you build yeah. |
|
@sl0thentr0py I think I may help with that improvement (not using an omnibus docker image for everything) It'll take a few days at least though. What's the best way to unblock right now? |
|
current fix is okay then for me! will leave it to @asottile-sentry to approve |
|
people are waiting on the release, could we get this out? @asottile-sentry |
I'm not blocking anything -- it just seems like a bad idea to use rabbitmq's builds rather than official ones |
|
If @BYK is going to work on making Docker images configurable, this seems like a good patch to get releases out in the meantime? |
|
To make it clear here: I did search for official builds for quite a while and that's how I ended up with the RabbitMQ builds. If anyone has a better idea, happy to go with that. @whatyouhide @sl0thentr0py - What's the main issue with the omnibus Debian image? What would you have used if it was not this? |
|
just the hexpm/elixir base image directly |
|
@sl0thentr0py would love to replicate what they do in our own image but I can't wrap my head around it (probably because Elixir is alien to me). Any pointers? Bob the builder doesn't really help 😅 |
|
it's building from source, I would rather not have that on our side since it can change and we would have to maintain that. Is it possible to do this |
|
We can definitely do that. I checked their Dockerfile and looks like that's what they do? |
|
@sl0thentr0py @BYK releases are still blocked for the Elixir SDK. Anything I can do to help? |
|
i approved let's just try this |
|
@sl0thentr0py any news here? |
|
we just need to approve the release again, but Stephanie is out so I'll ping some other manager |
This should fix the Elixir release issues: https://github.com/getsentry/publish/actions/runs/13697376301/job/38302799587#step:12:94