-
-
Notifications
You must be signed in to change notification settings - Fork 17
fix: Don't fail when there are no releases #602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
I was pretty sure the conclusion from #342 was that this wasn't really fixable for two reasons:
|
It is fixable (at least to me), here's my reasoning:
Not necessarily as this only applies to the very first release. At that point one can tweak the script. In any case, I use
The workaround for this is just getting all the commits up to |
I'd rather we fix this properly and deprecate the 2-arg release bump script and make a bump-version-v2.sh or whatever
I assume you mean to the beginning of the history? |
Up to |
Why though? Having the old version available is definitely useful and making the script be called with 1 arg for the initial release and 2 args for the rest seems like adding unnecessary complexity. What's your main concern here? I am lax as this only applies to new projects and shouldn't have any impact on existing ones. |
I don't think the old version is useful. and I don't think sending a bogus value for the first release makes sense either |
@asottile-sentry I cannot justify the change you are asking for from a cost benefit standpoint. Making a deprecation for all existing projects, forcing an analysis and migration with a way to manage a breaking change for a fix that only affects the first release of new projects doesn't seem cost effective to me. What am I missing from your perspective? |
Fixes #342.