Skip to content

Conversation

@philprime
Copy link
Member

Adds a tvOS dashboard app created for the Potato stocks usage

@philprime philprime self-assigned this Apr 1, 2025
@philprime philprime marked this pull request as ready for review April 1, 2025 14:30
@philprime philprime requested a review from a team as a code owner April 1, 2025 14:30
@codecov
Copy link

codecov bot commented Apr 1, 2025

Bundle Report

Bundle size has no change ✅

@philprime philprime changed the title feat(pototoa): add MVP for tvOS stocks dashboard app feat(pototoa): add MVP for tvOS dashboard app Apr 1, 2025
@codecov
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 25.36%. Comparing base (bedf514) to head (433f1a2).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #292   +/-   ##
=========================================
  Coverage     25.36%   25.36%           
  Complexity      323      323           
=========================================
  Files            77       77           
  Lines          3233     3233           
=========================================
  Hits            820      820           
  Misses         2413     2413           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

if offset < -contentWidth {
offset += contentWidth
}
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: NewsTickerView ticker loop resets prematurely due to unmeasured width

The ticker animation continuously checks if offset < -contentWidth to loop, but contentWidth starts at 0 and is only set asynchronously in the onAppear callback. This causes the reset condition offset < 0 to trigger immediately when animation begins, causing the offset to continuously jump back to 0 instead of smoothly animating until the content width is properly measured.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants