Skip to content

feat: Close modal with ESC key #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cleptric merged 3 commits into from
Nov 19, 2025
Merged

feat: Close modal with ESC key #338

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e7bca64
feat: Close modal with ESC key
itaybre Aug 22, 2025
aaf606a
Ensure the event listener is properly unmounted
itaybre Nov 19, 2025
7619f2b
Merge branch 'main' into itaybre/close_with_esc
cleptric Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions frontend/src/views/Shop.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,10 +232,16 @@ export default {
code: null,
}
},
beforeUnmount() {
document.removeEventListener('keydown', this.handleEscKey)
},
methods: {
openModal(product) {
this.product = product
this.modalOpen = true
// Remove first to prevent duplicate event listeners
document.removeEventListener('keydown', this.handleEscKey)
document.addEventListener('keydown', this.handleEscKey)
},
closeModal() {
this.product = null
Expand All @@ -246,6 +252,12 @@ export default {
this.purchaseSuccess = false
this.code = null
this.purchaseMode = 'myself'
document.removeEventListener('keydown', this.handleEscKey)
},
handleEscKey(event) {
if (event.key === 'Escape' && this.modalOpen) {
this.closeModal()
}
},
async purchase() {
this.loading = true
Expand Down
Loading