Skip to content

Conversation

@cleptric
Copy link
Member

No description provided.

@cleptric cleptric requested a review from a team as a code owner November 20, 2025 14:45
@cleptric cleptric self-assigned this Nov 20, 2025
metrics()->count(
'gibpotato.message.quick_win',
1,
);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Metric recording conditional on span existence only

The metrics()->count() call is placed inside the if ($span !== null) block, meaning metrics will only be recorded when a span exists. This is inconsistent with AwardService where the same metric recording pattern is placed outside the conditional block, ensuring metrics are always recorded regardless of span availability. Metrics should be recorded unconditionally to maintain consistent observability.

Fix in Cursor Fix in Web

@codecov
Copy link

codecov bot commented Nov 20, 2025

Bundle Report

Bundle size has no change ✅

@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

❌ Patch coverage is 96.87500% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 26.06%. Comparing base (bedf514) to head (e2d3743).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/Middleware/SentryMiddleware.php 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #363      +/-   ##
============================================
+ Coverage     25.36%   26.06%   +0.70%     
  Complexity      323      323              
============================================
  Files            77       77              
  Lines          3233     3265      +32     
============================================
+ Hits            820      851      +31     
- Misses         2413     2414       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cleptric cleptric merged commit c28bbe8 into main Nov 20, 2025
13 checks passed
@cleptric cleptric deleted the metrics branch November 20, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants