Skip to content

fix: reorder columns in Leaderboard component for consistency #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JoshuaMoelans wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: reorder columns in Leaderboard component for consistency #368

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c67404d
Reorder columns in Leaderboard component
JoshuaMoelans Dec 12, 2025
d6d6c00
Merge branch 'main' into fix/leaderboard_column_order
cleptric Feb 13, 2026
6c192d5
Merge branch 'main' into fix/leaderboard_column_order
cleptric Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions frontend/src/components/Leaderboard.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@
<th scope="col" class="py-3.5 px-3 text-left text-sm font-semibold">
Person
</th>
<th scope="col" class="hidden md:table-cell py-3.5 px-3 text-right text-sm font-semibold">
Sent
</th>
<th scope="col" class="hidden md:table-cell relative py-3.5 pl-3 text-right text-sm font-semibold">
Received
</th>
<th scope="col" class="hidden md:table-cell py-3.5 px-3 text-right text-sm font-semibold">
Sent
</th>
Copy link
Copy Markdown

@cursor cursor Bot Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Header and data cell CSS classes are mismatched

Low Severity

The column reorder used two different strategies: the <th> elements were physically moved (keeping their CSS), but the <td> elements only had their text content swapped (keeping their CSS in place). This means the positional styling classes (relative, pl-3 vs px-3, pr-4) are now mismatched between each header and its data cells. For example, the "Received" header has relative pl-3 while its data cell has px-3, and the "Sent" header has px-3 while its data cell has relative pl-3 pr-4.

Additional Locations (1)

Fix in Cursor Fix in Web

Copy link
Copy Markdown
Member

@cleptric cleptric Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoshuaMoelans 👀

</tr>
</thead>
<tbody class="divide-y divide-gray-200">
Expand All @@ -30,10 +30,10 @@
</div>
</td>
<td class="hidden md:table-cell whitespace-nowrap py-4 px-3 text-right text-sm">
{{ user.sent_count ?? 0 }}
{{ user.received_count ?? 0 }}
</td>
<td class="hidden md:table-cell relative whitespace-nowrap py-4 pl-3 pr-4 text-right text-sm">
{{ user.received_count ?? 0 }}
{{ user.sent_count ?? 0 }}
</td>
</tr>
</tbody>
Expand Down
Loading