Fix shell injection vulnerability in release workflow#123
Open
fix-it-felix-sentry[bot] wants to merge 1 commit intomainfrom
Open
Fix shell injection vulnerability in release workflow#123fix-it-felix-sentry[bot] wants to merge 1 commit intomainfrom
fix-it-felix-sentry[bot] wants to merge 1 commit intomainfrom
Conversation
Move github.ref_name from direct interpolation to environment variable to prevent potential code injection attacks. This addresses the security finding where untrusted GitHub context data could be used to inject malicious code into the runner. Fixes: https://linear.app/getsentry/issue/VULN-1591 Fixes: https://linear.app/getsentry/issue/CCMRG-2208 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a high-severity security vulnerability where untrusted GitHub context data (
github.ref_name) was being used directly in a shell script, potentially allowing code injection attacks.Changes
github.ref_nameto an environment variableREF_NAMEThis prevents attackers from injecting malicious code through branch names or other GitHub context data that could be controlled by untrusted users.
Security Impact
Severity: High
The vulnerability allowed potential code injection in GitHub Actions runners, which could lead to:
References
🤖 Generated with Claude Code