feat(publish): Use Release GitHub App for publishing instead of getsentry-bot - 2nd attempt #5110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The token that's currently in use,
secrets.GH_SENTRY_BOT_PATis owned by getsentry-bot, which by default does not have access to newly created repos, and the publish workflow will fail if the permissions are not granted explicitly.Replacing it with a short-live token from Release Bot GitHub App which has write access to all repos in getsentry.
Our 1st attempt was reverted because token from GitHub App does not have a username tied to it, which causes craft to fail.
We updated craft to use
placeholderusernameas the value doesn't matter as long as the token is valid.