Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(publish): Use Release GitHub App for publishing instead of getsentry-bot - 2nd attempt #5110

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

Jeffreyhung
Copy link
Member

The token that's currently in use, secrets.GH_SENTRY_BOT_PAT is owned by getsentry-bot, which by default does not have access to newly created repos, and the publish workflow will fail if the permissions are not granted explicitly.

Replacing it with a short-live token from Release Bot GitHub App which has write access to all repos in getsentry.


Our 1st attempt was reverted because token from GitHub App does not have a username tied to it, which causes craft to fail.

We updated craft to use placeholderusername as the value doesn't matter as long as the token is valid.

@Jeffreyhung Jeffreyhung requested a review from a team as a code owner February 24, 2025 17:56
Copy link
Member

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile-sentry asottile-sentry merged commit c0837f4 into main Feb 24, 2025
5 checks passed
@asottile-sentry asottile-sentry deleted the use-github-app-for-publish-workflow branch February 24, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants