Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(quota): Revert application of indexed quota on nested spans #4108

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(quota): Revert application of indexed quota on nested spans #4108

wants to merge 2 commits into from
+118 −210

Conversation

jjbayer
Copy link
Member

@jjbayer jjbayer commented Oct 4, 2024 •
edited
Loading

Reverts #4097.

Never really worked, relied on a bug in fast-path rate limiting to even pass the tests.

#skip-changelog

@jjbayer jjbayer marked this pull request as ready for review October 4, 2024 13:27
@jjbayer jjbayer requested a review from a team as a code owner October 4, 2024 13:27
loewenheim
loewenheim approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@loewenheim loewenheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubberstamp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dav1dde Dav1dde Dav1dde approved these changes

@loewenheim loewenheim loewenheim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjbayer @Dav1dde @loewenheim