Expose the augmented callback request type - #818
Open
adamtheturtle wants to merge 2 commits into
Open
adamtheturtle wants to merge 2 commits into
adamtheturtle wants to merge 2 commits into
Conversation
markstory
reviewed
Sep 14, 2026
Co-authored-by: Mark Story <mark@mark-story.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Responses adds
paramsandreq_kwargsto callback requests, but types callbacks asPreparedRequest, forcing consumers to usegetattror suppressions.This exposes
CallbackRequest(plus its parameter types) and uses it for callback annotations. It remains aPreparedRequestalias at runtime because Responses augments existing requests rather than creating a subclass.Verified with pre-commit, mypy, and all 233 tests on Python 3.8–3.14.