feat(autofix): Tie code changes to the step #1687
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennmueng
force-pushed
the
jenn/autofix/changes-tied-to-step
branch
from
b19fba2 to
ad4ab89
Compare
jennmueng
commented
Jan 15, 2025
| @@ -204,6 +200,45 @@ def ask_user_question(self, question: str): | |||
|
|
|||
| cur.status = AutofixStatus.WAITING_FOR_USER_RESPONSE | |||
|
|
|||
| def add_user_message(self, message: str, memory_index: int): | |||
There was a problem hiding this comment.
tacked this change on for cleanliness
jennmueng
commented
Jan 15, 2025
| @@ -38,18 +38,6 @@ | |||
| RepoIdentifiers = tuple[RepoExternalId, RepoInternalId] | |||
|
|
|||
|
|
|||
| class AutofixCodebaseStateManager(CodebaseStateManager): | |||
jennmueng
commented
Jan 15, 2025
| self.event_manager = event_manager | ||
| self.state = state | ||
|
|
||
| # TODO: Remove this when we no longer need the backwards compatibility. | ||
| self.event_manager.migrate_step_keys() |
jennmueng
commented
Jan 15, 2025
Comment on lines
-75
to
-81
| with state.update() as cur: | ||
| for repo in request.repos: | ||
| if repo.external_id not in cur.codebases: | ||
| cur.codebases[repo.external_id] = CodebaseState( | ||
| file_changes=[], | ||
| repo_external_id=repo.external_id, | ||
| ) |
There was a problem hiding this comment.
this is no longer needed as the new codebase states are initialized inside event_manager.send_coding_start
jennmueng
force-pushed
the
jenn/autofix/changes-tied-to-step
branch
from
4b72e9a to
a8ca349
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of storing the
file_changesin the root of the state, it stores it inside thechangesstep. Doing so now entirely contains the plan+code workflow inside thechangesstep. This includes moving the insights from the default step to thechangesstep. This now makes us entirely consolidate things related to a workflow to a single step. Will follow up with moving root cause into a single step as well, and entirely remove the notion of having a "default" step for insights and another step for the result.Method of migration
So we'll be migrating all existing Autofix runs to this new model, we have a migration that migrates all run states over by copying over the file changes and codebase state to this new more organized format. However, we won't be deleting the existing fields to allow for current frontends to still render fine and also allow for ease of rolling back in case something goes wrong.