Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ai): Fix gemini tool usage #1892

Merged
merged 7 commits into from
Feb 7, 2025
Merged

fix(ai): Fix gemini tool usage #1892

merged 7 commits into from
Feb 7, 2025

Conversation

jennmueng
Copy link
Member

We were not handling Gemini tools correctly

  1. In the tool type, we were passing in the tool and its arguments again not the tool responses
  2. Gemini expects all tools to be sent back in a single Content not as multiple tool messages like we have

@jennmueng jennmueng requested a review from roaga February 7, 2025 22:18
roaga
roaga approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@roaga roaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty

@roaga
Copy link
Member

roaga commented Feb 7, 2025 •
edited
Loading

oh the mypy issue is back, probably can just ignore it

@jennmueng jennmueng marked this pull request as ready for review February 7, 2025 22:52
@jennmueng jennmueng requested a review from a team as a code owner February 7, 2025 22:52
@jennmueng jennmueng enabled auto-merge (squash) February 7, 2025 22:52
@jennmueng jennmueng merged commit 2747f20 into main Feb 7, 2025
6 checks passed
@jennmueng jennmueng deleted the jenn/gemini-tools branch February 7, 2025 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roaga roaga roaga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jennmueng @roaga