feat(distribution): Enable build uploads when distribution is enabled#1011
Merged
Conversation
Previously, build uploads only occurred when size analysis was enabled. This change allows builds to be uploaded when either size analysis is enabled or when a variant is configured in distribution.enabledVariants. This enables users to use build distribution independently of size analysis features, while still supporting both features together. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
runningcode
requested review from
adinauer,
chromy,
lcian,
markushi,
rbro112,
romtsn and
stefanosiano
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enables build uploads when distribution is configured, decoupling it from size analysis.
Previously, build uploads only occurred when
sizeAnalysis.enabledwastrue. This change allows builds to be uploaded when either:distribution.enabledVariantsThis allows users to use build distribution independently of size analysis features, while still supporting both features working together.
Changes
AndroidComponentsConfig.ktto check bothsizeAnalysis.enabledanddistribution.enabledVariantswhen deciding whether to configure upload tasksbuildConfigurationparameter continues to be used for both features to organize builds#skip-changelog
🤖 Generated with Claude Code