fix(snapshot): Use string values for all tags#1199
Merged
Conversation
Tags should use string values instead of raw types so they are serialized correctly in the sidecar JSON. Changed the map type from Map<String, Any> to Map<String, String> and converted numeric and boolean values with .toString(). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
runningcode
requested review from
adinauer,
chromy,
markushi,
rbro112 and
romtsn
as code owners
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
cameroncooke
left a comment
cameroncooke
left a comment
There was a problem hiding this comment.
Should we just remove tags as they aren't supported by Snapshots to align with iOS?
Contributor
Author
|
They are implemented and validated as strings on the backend. The issue is that we are sending up |
NicoHinderling
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Map<String, Any>toMap<String, String>in the generated snapshot sidecarfont_scale,api_level,width_dp,height_dp) now use.toString()show_system_ui,show_background) now use"true"instead oftrueFixes EME-1156
🤖 Generated with Claude Code