Add stricter plugin validation and fix issues.#894
Merged
Conversation
runningcode
requested review from
adinauer,
lcian,
markushi,
romtsn and
stefanosiano
as code owners
romtsn
reviewed
May 21, 2025
romtsn
reviewed
May 21, 2025
romtsn
reviewed
May 30, 2025
romtsn
approved these changes
May 30, 2025
This adds stricter plugin validation to check that all tasks are declared cacheable or not and all properties are correctly marked. This also fixes issues that the task discovered and adds it as a dependency to the check task.
Co-authored-by: Roman Zavarnitsyn <rom4ek93@gmail.com>
runningcode
force-pushed
the
no/validate-plugins
branch
from
bb49b55 to
c2cde57
Compare
…ntryUploadProguardMappingsTask.kt Co-authored-by: Roman Zavarnitsyn <rom4ek93@gmail.com>
runningcode
force-pushed
the
no/validate-plugins
branch
from
c2cde57 to
6989366
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
This adds stricter plugin validation to check that all tasks are
declared cacheable or not and all properties are correctly marked.
This also fixes issues that the task discovered and adds it as a
dependency to the check task.
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
🔮 Next steps