Allow kotlin pre-releases in KotlinCompilerPlugin#972
Merged
Conversation
stefanosiano
requested review from
adinauer,
chromy,
lcian,
markushi,
rbro112,
romtsn and
runningcode
as code owners
Contributor
Author
|
I just don't know how to properly test it |
romtsn
approved these changes
Sep 9, 2025
romtsn
left a comment
romtsn
left a comment
Member
There was a problem hiding this comment.
LGTM.
I think you could test by adopting this integration test and using e.g. a preview kotlin version like 1.8.20-RC2
romtsn
reviewed
Sep 11, 2025
* New sentry command # Conflicts: # examples/android-guardsquare-proguard/sentry.properties # plugin-build/sentry-cli.properties * not working * adding tests * Size analysis working * Add extension * working on test * remove shadow * Add tests and CI check * Disable uploading by default * Remove second truth * Use build instead of mobile-app command * Add SentryPluginIntegrationTest * Use alpha version * Improve python server functionality.
* Add VCS info extension for build uploads - Create VcsInfoExtension with vcs related sentry-cli build upload params - Add vcsInfo property and configuration function to SentryPluginExtension - Update SentryUploadAppArtifactTask to pass VCS parameters to sentry-cli - Support head/base SHA, repo names, refs, VCS provider, and PR number * Add changelog entry for VCS info extension 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * Add documentation clarifying VcsInfoExtension scope 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * Apply spotless code formatting Fix comment formatting in VcsInfoExtension to comply with project style guidelines. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * Add test for VCS info CLI arguments in upload task Verify that all VCS information from the VcsInfoExtension is correctly passed as command line arguments to the Sentry CLI during app artifact uploads. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * Apply spotless formatting to test file Format long assertion lines in VCS info test for better readability. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>
Bumps [actions/github-script](https://github.com/actions/github-script) from 7 to 8. - [Release notes](https://github.com/actions/github-script/releases) - [Commits](actions/github-script@v7...v8) --- updated-dependencies: - dependency-name: actions/github-script dependency-version: '8' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5 to 6. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v5...v6) --- updated-dependencies: - dependency-name: actions/setup-python dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: GitHub <noreply@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Copied SemVer implementation to SentryKotlinCompilerPlugin
💡 Motivation and Context
Closes #955
💚 How did you test it?
📝 Checklist
🔮 Next steps