build(macos): Sign macOS binaries #2401
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szokeasaurusrex
force-pushed
the
szokeasaurusrex/sign-macos
branch
from
6e1650f to
4549c90
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/sign-macos
branch
from
4549c90 to
e33d3ac
Compare
BYK
approved these changes
Feb 21, 2025
Comment on lines
+129
to
+130
| echo $APPLE_CERT_DATA | base64 --decode > ${{ env.APPLE_CERT_PATH }} | ||
| echo $APPLE_API_KEY | base64 --decode > ${{ env.APPLE_API_KEY_PATH }} |
There was a problem hiding this comment.
Safer
Suggested change
| echo $APPLE_CERT_DATA | base64 --decode > ${{ env.APPLE_CERT_PATH }} | |
| echo $APPLE_API_KEY | base64 --decode > ${{ env.APPLE_API_KEY_PATH }} | |
| echo "$APPLE_CERT_DATA" | base64 --decode > ${{ env.APPLE_CERT_PATH }} | |
| echo "$APPLE_API_KEY" | base64 --decode > ${{ env.APPLE_API_KEY_PATH }} |
mdtro
reviewed
Mar 4, 2025
Comment on lines
+127
to
+130
| - name: Install `rcodesign` | ||
| run: | | ||
| curl -L https://github.com/indygreg/apple-platform-rs/releases/download/apple-codesign%2F0.29.0/apple-codesign-0.29.0-x86_64-unknown-linux-musl.tar.gz | tar -xz --strip-components=1 | ||
| mv rcodesign /usr/local/bin/rcodesign |
There was a problem hiding this comment.
Recommend adding a step here that verifies the expected SHA256 checksum.
https://github.com/indygreg/apple-platform-rs/releases/download/apple-codesign%2F0.29.0/apple-codesign-0.29.0-aarch64-unknown-linux-musl.tar.gz.sha256
4af92c87ddf52f5f2d1258a3b4e56c7dcb8f1b2468df744976c5f139e031961f
There was a problem hiding this comment.
I think this is a good idea as I forgot releases can be mutable.
There was a problem hiding this comment.
Added to Spotlight here: https://github.com/getsentry/spotlight/pull/722/files
There was a problem hiding this comment.
Note that the SHA256 @mdtro shared is for arm64 so different in my PR.
There was a problem hiding this comment.
No worries, I made the same mistake even when I thought I was looking very closely :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1882