test: Use XCTestExpectation in SDKInternalTests #5828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the dispatch group with a XCTestExpectation to get a failure message when the wait times out. Contributes to GH-5789
philipphofmann
requested review from
itaybre,
noahsmartin and
philprime
as code owners
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
![seer-by-sentry[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky tests
To view more test analytics, go to the Test Analytics Dashboard |
Co-authored-by: Philip Niedertscheider <[email protected]>
philipsawyerdd
added a commit
to justin-doordash/sentry-cocoa
that referenced
this pull request
Sep 25, 2025
…)" This reverts commit d88a5e4.
philipsawyerdd
added a commit
to justin-doordash/sentry-cocoa
that referenced
this pull request
Sep 25, 2025
…)" This reverts commit d88a5e4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the dispatch group with a XCTestExpectation to get a failure message when the wait times out.
Contributes to GH-5789