test: add unit tests for PR#5806 #5833
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codecov-ai[bot]](https://avatars.githubusercontent.com/in/797565?s=80&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## philprime/strict-nullability-16 #5833 +/- ##
=====================================================================
+ Coverage 86.622% 86.652% +0.030%
=====================================================================
Files 423 423
Lines 36405 36405
Branches 17225 17229 +4
=====================================================================
+ Hits 31535 31546 +11
+ Misses 4822 4811 -11
Partials 48 48 see 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
Yeah, no thank you. |
Yes indeed 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test: add unit tests for PR#5806
This PR adds comprehensive unit tests for the changes introduced in PR#5806.
Changes:
Add comprehensive test coverage for the sentry_sliceTraceProfileGPUData function focusing on the null safety improvements including NSNull value handling, missing value key handling, and enhanced most recent recording logic.