Skip to content

Remove sentry serializable public api #5988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −6
Draft

Remove sentry serializable public api #5988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Sources/Sentry/Public/Sentry.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,9 @@
# import <Sentry/SentrySampleDecision.h>
# import <Sentry/SentrySamplingContext.h>
# import <Sentry/SentryScope.h>
# import <Sentry/SentrySerializable.h>
# if !SDK_V9
# import <Sentry/SentrySerializable.h>
# endif
# import <Sentry/SentrySpanContext.h>
# import <Sentry/SentrySpanId.h>
# import <Sentry/SentrySpanProtocol.h>
Expand All @@ -50,3 +52,3 @@
# import <Sentry/SentryUser.h>
# import <Sentry/SentryWithoutUIKit.h>
#endif // __has_include(<Sentry/Sentry.h>)
4 changes: 3 additions & 1 deletion Sources/Sentry/Public/SentryWithoutUIKit.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,9 @@ FOUNDATION_EXPORT const unsigned char SentryVersionString[];
# import <SentryWithoutUIKit/SentrySampleDecision.h>
# import <SentryWithoutUIKit/SentrySamplingContext.h>
# import <SentryWithoutUIKit/SentryScope.h>
# import <SentryWithoutUIKit/SentrySerializable.h>
# if !SDK_V9
# import <SentryWithoutUIKit/SentrySerializable.h>
# endif
# import <SentryWithoutUIKit/SentrySpanContext.h>
# import <SentryWithoutUIKit/SentrySpanId.h>
# import <SentryWithoutUIKit/SentrySpanProtocol.h>
Expand Down
7 changes: 6 additions & 1 deletion Sources/Sentry/include/SentrySpan.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,12 @@ NS_ASSUME_NONNULL_BEGIN
@class SentryFramesTracker;
#endif // SENTRY_HAS_UIKIT

@interface SentrySpan : NSObject <SentrySpan, SentrySerializable>
@interface SentrySpan : NSObject
#if !SDK_V9
<SentrySpan, SentrySerializable>
#else
<SentrySpan>
#endif
SENTRY_NO_INIT

/**
Expand Down
3 changes: 2 additions & 1 deletion Sources/Swift/Integrations/SessionReplay/RRWeb/SentryRRWebEvent.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ enum SentryRRWebEventType: Int {
}

@objc(SentryRRWebEvent)
@_spi(Private) public protocol SentryRRWebEventProtocol: SentrySerializable {
@_spi(Private) public protocol SentryRRWebEventProtocol {
func serialize() -> [String: Any]
}

@objcMembers
Expand Down
4 changes: 2 additions & 2 deletions Sources/Swift/SentryAppState.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
@_implementationOnly import _SentryPrivate
import Foundation

@objcMembers @_spi(Private) public class SentryAppState: NSObject, SentrySerializable {
@objcMembers @_spi(Private) public class SentryAppState: NSObject {

public private(set) var releaseName: String?
public private(set) var osVersion: String
Expand Down Expand Up @@ -129,4 +129,4 @@ import Foundation

return data
}
}
}
Loading