chore: Remove profiling API deprecated in V9

Sources/Sentry/Public/SentryOptions.h

@@ -531,22 +531,6 @@ typedef void (^SentryProfilingConfigurationBlock)(SentryProfileOptions *_Nonnull
 @property (nullable, nonatomic, copy) SentryProfilingConfigurationBlock configureProfiling;
 
 #    if !SDK_V9
-/**
- * @warning This is an experimental feature and may still have bugs.
- * Set to @c YES to run the profiler as early as possible in an app launch, before you would
- * normally have the opportunity to call @c SentrySDK.start . If @c profilesSampleRate is nonnull,
- * the @c tracesSampleRate and @c profilesSampleRate are persisted to disk and read on the next app
- * launch to decide whether to profile that launch.
- * @warning If @c profilesSampleRate is @c nil then a continuous profile will be started on every
- * launch; if you desire sampling profiled launches, you must compute your own sample rate to decide
- * whether to set this property to @c YES or @c NO .
- * @warning This property is deprecated and will be removed in a future version of the SDK. See
- * @c SentryProfileOptions.startOnAppStart and @c SentryProfileOptions.lifecycle .
- * @note Profiling is automatically disabled if a thread sanitizer is attached.
- */
-@property (nonatomic, assign) BOOL enableAppLaunchProfiling DEPRECATED_MSG_ATTRIBUTE(
-    "This property is deprecated and will be removed in a future version of the SDK. See "
-    "SentryProfileOptions.startOnAppStart and SentryProfileOptions.lifecycle");
 
 /**
  * @note Profiling is not supported on watchOS or tvOS.
@@ -607,19 +591,6 @@ typedef void (^SentryProfilingConfigurationBlock)(SentryProfileOptions *_Nonnull
  */
 @property (nonatomic, assign, readonly) BOOL isProfilingEnabled DEPRECATED_MSG_ATTRIBUTE(
     "This property is deprecated and will be removed in a future version of the SDK");
-
-/**
- * @brief Whether to enable the sampling profiler.
- * @note Profiling is not supported on watchOS or tvOS.
- * @deprecated Use @c profilesSampleRate instead. Setting @c enableProfiling to @c YES is the
- * equivalent of setting @c profilesSampleRate to @c 1.0  If @c profilesSampleRate is set, it will
- * take precedence over this setting.
- * @note Default is @c NO.
- * @note Profiling is automatically disabled if a thread sanitizer is attached.
- */
-@property (nonatomic, assign) BOOL enableProfiling DEPRECATED_MSG_ATTRIBUTE(
-    "Use profilesSampleRate or profilesSampler instead. This property will be removed in a future "
-    "version of the SDK");
 #    endif // !SDK_V9
 #endif // SENTRY_TARGET_PROFILING_SUPPORTED
 

Sources/Sentry/SentryHub.m

@@ -460,14 +460,6 @@ - (SentryTracer *)startTransactionWithContext:(SentryTransactionContext *)transa
                                        sampleRate:tracesSamplerDecision.sampleRate
                                        sampleRand:tracesSamplerDecision.sampleRand];
 
-#if SENTRY_TARGET_PROFILING_SUPPORTED && !SDK_V9
-    if (![self.client.options isContinuousProfilingEnabled]) {
-        SentrySamplerDecision *profilesSamplerDecision = sentry_sampleTraceProfile(
-            samplingContext, tracesSamplerDecision, self.client.options);
-        configuration.profilesSamplerDecision = profilesSamplerDecision;
-    }
-#endif // SENTRY_TARGET_PROFILING_SUPPORTED && !SDK_V9
-
     SentryTracer *tracer = [[SentryTracer alloc] initWithTransactionContext:transactionContext
                                                                         hub:self
                                                               configuration:configuration];

Sources/Sentry/SentryOptions.m

@@ -120,7 +120,6 @@ - (instancetype)init
         self.tracesSampleRate = nil;
 #if SENTRY_TARGET_PROFILING_SUPPORTED
 #    if !SDK_V9
-        _enableProfiling = NO;
 #        pragma clang diagnostic push
 #        pragma clang diagnostic ignored "-Wdeprecated-declarations"
         self.profilesSampleRate = SENTRY_INITIAL_PROFILES_SAMPLE_RATE;
@@ -308,7 +307,7 @@ - (void)setProfilesSampleRate:(NSNumber *)profilesSampleRate
 - (BOOL)isProfilingEnabled
 {
     return (_profilesSampleRate != nil && [_profilesSampleRate doubleValue] > 0)
-        || _profilesSampler != nil || _enableProfiling;
+        || _profilesSampler != nil;
 }
 
 - (BOOL)isContinuousProfilingEnabled
@@ -318,7 +317,7 @@ - (BOOL)isContinuousProfilingEnabled
     // this looks a little weird with the `!self.enableProfiling` but that actually is the
     // deprecated way to say "enable trace-based profiling", which necessarily disables continuous
     // profiling as they are mutually exclusive modes
-    return _profilesSampleRate == nil && _profilesSampler == nil && !self.enableProfiling;
+    return _profilesSampleRate == nil && _profilesSampler == nil;
 #        pragma clang diagnostic pop
 }
 
@@ -342,24 +341,6 @@ - (BOOL)isProfilingCorrelatedToTraces
         || (_profiling != nil && _profiling.lifecycle == SentryProfileLifecycleTrace);
 #    endif // SDK_V9
 }
-
-#    if !SDK_V9
-- (void)setEnableProfiling_DEPRECATED_TEST_ONLY:(BOOL)enableProfiling_DEPRECATED_TEST_ONLY
-{
-#        pragma clang diagnostic push
-#        pragma clang diagnostic ignored "-Wdeprecated-declarations"
-    self.enableProfiling = enableProfiling_DEPRECATED_TEST_ONLY;
-#        pragma clang diagnostic pop
-}
-
-- (BOOL)enableProfiling_DEPRECATED_TEST_ONLY
-{
-#        pragma clang diagnostic push
-#        pragma clang diagnostic ignored "-Wdeprecated-declarations"
-    return self.enableProfiling;
-#        pragma clang diagnostic pop
-}
-#    endif // !SDK_V9
 #endif // SENTRY_TARGET_PROFILING_SUPPORTED
 
 #if SENTRY_UIKIT_AVAILABLE

Sources/Sentry/SentrySampling.m

@@ -87,43 +87,6 @@
 
 #if SENTRY_TARGET_PROFILING_SUPPORTED
 
-#    if !SDK_V9
-SentrySamplerDecision *
-sentry_sampleTraceProfile(SentrySamplingContext *context,
-    SentrySamplerDecision *tracesSamplerDecision, SentryOptions *options)
-{
-    // Profiles are always undersampled with respect to traces. If the trace is not sampled,
-    // the profile will not be either. If the trace is sampled, we can proceed to checking
-    // whether the associated profile should be sampled.
-    if (tracesSamplerDecision.decision != kSentrySampleDecisionYes) {
-        return [[SentrySamplerDecision alloc] initWithDecision:kSentrySampleDecisionNo
-                                                 forSampleRate:nil
-                                                withSampleRand:nil];
-    }
-
-    // Backward compatibility for clients that are still using the enableProfiling option.
-#        pragma clang diagnostic push
-#        pragma clang diagnostic ignored "-Wdeprecated-declarations"
-    if (options.enableProfiling) {
-        return [[SentrySamplerDecision alloc] initWithDecision:kSentrySampleDecisionYes
-                                                 forSampleRate:@1.0
-                                                withSampleRand:@1.0];
-    }
-
-    NSNumber *callbackRate = _sentry_samplerCallbackRate(
-        options.profilesSampler, context, SENTRY_DEFAULT_PROFILES_SAMPLE_RATE);
-#        pragma clang diagnostic pop
-    if (callbackRate != nil) {
-        return _sentry_calcSample(callbackRate);
-    }
-
-#        pragma clang diagnostic push
-#        pragma clang diagnostic ignored "-Wdeprecated-declarations"
-    return _sentry_calcSampleFromNumericalRate(options.profilesSampleRate);
-#        pragma clang diagnostic pop
-}
-#    endif // !SDK_V9
-
 SentrySamplerDecision *
 sentry_sampleProfileSession(float sessionSampleRate)
 {

Sources/Sentry/SentyOptionsInternal.m

@@ -364,15 +364,6 @@ + (BOOL)validateOptions:(NSDictionary<NSString *, id> *)options
         sentryOptions.profilesSampler = options[@"profilesSampler"];
     }
 #        pragma clang diagnostic pop
-
-#        pragma clang diagnostic push
-#        pragma clang diagnostic ignored "-Wdeprecated-declarations"
-    [self setBool:options[@"enableProfiling"]
-            block:^(BOOL value) { sentryOptions.enableProfiling = value; }];
-
-    [self setBool:options[NSStringFromSelector(@selector(enableAppLaunchProfiling))]
-            block:^(BOOL value) { sentryOptions.enableAppLaunchProfiling = value; }];
-#        pragma clang diagnostic pop
 #    endif // !SDK_V9
 #endif // SENTRY_TARGET_PROFILING_SUPPORTED
 

Sources/Sentry/include/SentrySampling.h

@@ -14,16 +14,6 @@ SENTRY_EXTERN SentrySamplerDecision *sentry_sampleTrace(
     SentrySamplingContext *context, SentryOptions *options);
 
 #if SENTRY_TARGET_PROFILING_SUPPORTED
-/**
- * Determines whether a profile should be sampled based on the context, options, and
- * whether the trace corresponding to the profile was sampled, to decide whether to configure the
- * next launch to start a trace profile.
- */
-#    if !SDK_V9
-SENTRY_EXTERN SentrySamplerDecision *sentry_sampleTraceProfile(SentrySamplingContext *context,
-    SentrySamplerDecision *tracesSamplerDecision, SentryOptions *options);
-#    endif // !SDK_V9
-
 SENTRY_EXTERN SentrySamplerDecision *sentry_sampleProfileSession(float sessionSampleRate);
 #endif // SENTRY_TARGET_PROFILING_SUPPORTED
 

Sources/Swift/Helper/SentryEnabledFeaturesBuilder.swift

@@ -19,14 +19,6 @@ import Foundation
             features.append("timeToFullDisplayTracing")
         }
 
-#if os(iOS) || os(macOS) || targetEnvironment(macCatalyst)
-        #if !SDK_V9
-        if options.enableAppLaunchProfiling {
-            features.append("appLaunchProfiling")
-        }
-        #endif // !SDK_V9
-#endif // os(iOS) || os(macOS) || targetEnvironment(macCatalyst)
-
 #if os(iOS) || os(tvOS)
 #if canImport(UIKit) && !SENTRY_NO_UIKIT
         if options.enablePreWarmedAppStartTracing {

Tests/SentryProfilerTests/SentryAppStartProfilingConfigurationTests.swift

@@ -65,8 +65,6 @@ private extension SentryAppStartProfilingConfigurationTests {
     @available(*, deprecated, message: "This is only marked as deprecated because enableAppLaunchProfiling is marked as deprecated. Once that is removed this can be removed.")
     private func performTest(expectedOptions: LaunchProfileOptions, shouldProfileLaunch: Bool) {
         let actualOptions = Options()
-        actualOptions.enableAppLaunchProfiling = expectedOptions.enableAppLaunchProfiling
-
         if let tracesSampleRate = expectedOptions.tracesSampleRate {
             actualOptions.tracesSampleRate = NSNumber(value: tracesSampleRate)
         } else {

Tests/SentryTests/Helper/SentryEnabledFeaturesBuilderTests.swift

@@ -1,4 +1,4 @@
 @_spi(Private) @testable import Sentry
 import XCTest
 
 @available(*, deprecated, message: "This is only marked as deprecated because enableAppLaunchProfiling is marked as deprecated. Once that is removed this can be removed.")
@@ -25,10 +25,6 @@
         options.enableTimeToFullDisplayTracing = true
         options.swiftAsyncStacktraces = true
 
-#if os(iOS) || os(macOS) || targetEnvironment(macCatalyst)
-        options.enableAppLaunchProfiling = true
-#endif // os(iOS) || os(macOS) || targetEnvironment(macCatalyst)
-
 #if os(iOS) || os(tvOS)
 #if canImport(UIKit) && !SENTRY_NO_UIKIT
         options.enablePreWarmedAppStartTracing = true
@@ -48,7 +44,7 @@
         XCTAssert(features.contains("swiftAsyncStacktraces"))
 
 #if os(iOS) || os(macOS) || targetEnvironment(macCatalyst)
         XCTAssert(features.contains("appLaunchProfiling"))
 #endif // os(iOS) || os(macOS) || targetEnvironment(macCatalyst)
 
 #if os(iOS) || os(tvOS)

Tests/SentryTests/SentryOptionsTest.m

@@ -1,4 +1,4 @@
 #import "SentryOptions.h"
 #import "SentryError.h"
 #import "SentryOptionsInternal.h"
 #import "SentrySDKInternal.h"
@@ -740,7 +740,6 @@
 #if SENTRY_TARGET_PROFILING_SUPPORTED
 #    pragma clang diagnostic push
 #    pragma clang diagnostic ignored "-Wdeprecated-declarations"
-    XCTAssertEqual(NO, options.enableProfiling);
     XCTAssertNil(options.profilesSampleRate);
     XCTAssertNil(options.profilesSampler);
 #    pragma clang diagnostic pop
@@ -1215,22 +1214,6 @@
     XCTAssertFalse([options isContinuousProfilingEnabled]);
 }
 
-- (void)testIsProfilingEnabled_EnableProfilingSet_IsEnabled
-{
-    SentryOptions *options = [[SentryOptions alloc] init];
-#    pragma clang diagnostic push
-#    pragma clang diagnostic ignored "-Wdeprecated-declarations"
-    options.enableProfiling = YES;
-#    pragma clang diagnostic pop
-
-    // This property now only refers to trace-based profiling, but renaming it would require a major
-    // rev
-    XCTAssertTrue(options.isProfilingEnabled);
-
-    XCTAssertNil(options.profilesSampleRate);
-    XCTAssertFalse([options isContinuousProfilingEnabled]);
-}
-
 - (void)testProfilesSampler
 {
     SentryTracesSamplerCallback sampler = ^(SentrySamplingContext *context) {
@@ -1360,17 +1343,6 @@
     XCTAssertIdentical(initialScope, options.initialScope);
 }
 
-#if SENTRY_TARGET_PROFILING_SUPPORTED
-#    pragma clang diagnostic push
-#    pragma clang diagnostic ignored "-Wdeprecated-declarations"
-- (void)testEnableAppLaunchProfilingDefaultValue
-{
-    SentryOptions *options = [self getValidOptions:@{}];
-    XCTAssertFalse(options.enableAppLaunchProfiling);
-}
-#    pragma clang diagnostic pop
-#endif // SENTRY_TARGET_PROFILING_SUPPORTED
-
 - (SentryOptions *)getValidOptions:(NSDictionary<NSString *, id> *)dict
 {
     NSError *error = nil;
@@ -1500,15 +1472,15 @@
 {
     // Opposite of default
     SentryOptions *options = [self getValidOptions:@{ property : @(!defaultValue) }];
     XCTAssertEqual(!defaultValue, [self getProperty:property of:options]);
 
     // Default
     options = [self getValidOptions:@{}];
     XCTAssertEqual(defaultValue, [self getProperty:property of:options]);
 
     // Garbage
     options = [self getValidOptions:@{ property : @"" }];
     XCTAssertEqual(NO, [self getProperty:property of:options]);
 }
 
 - (BOOL)getProperty:(NSString *)property of:(SentryOptions *)options