Skip to content

Conversation

noahsmartin
Copy link
Contributor

@noahsmartin noahsmartin commented Oct 16, 2025

Now that we just have one type left to migrate before moving all of the dependency container to Swift, I started moving some of the easier ones into Swift here

#skip-changelog

Closes #6443

cursor[bot]

This comment was marked as outdated.

Copy link

codecov bot commented Oct 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.957%. Comparing base (04435e6) to head (7cb2e5d).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #6442       +/-   ##
=============================================
+ Coverage   86.937%   86.957%   +0.019%     
=============================================
  Files          447       448        +1     
  Lines        37582     37577        -5     
  Branches     17432     17437        +5     
=============================================
+ Hits         32673     32676        +3     
+ Misses        4867      4858        -9     
- Partials        42        43        +1     
Files with missing lines Coverage Δ
Sources/Sentry/SentryDependencyContainer.m 90.254% <100.000%> (-0.123%) ⬇️
Sources/Sentry/SentrySessionReplayIntegration.m 87.364% <100.000%> (ø)
Sources/Swift/Helper/Dependencies.swift 100.000% <100.000%> (ø)
...wift/Helper/InfoPlist/SentryInfoPlistWrapper.swift 97.222% <100.000%> (-0.339%) ⬇️
...Replay/SentrySessionReplayEnvironmentChecker.swift 95.698% <100.000%> (ø)

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e21e059...7cb2e5d. Read the comment docs.

@noahsmartin noahsmartin force-pushed the beginMovingDependencies branch from 586de7a to 7cb2e5d Compare October 16, 2025 19:52
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1219.98 ms 1243.48 ms 23.50 ms
Size 23.75 KiB 1009.97 KiB 986.22 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
56d2052 1218.35 ms 1247.58 ms 29.23 ms
3c86ff3 1227.82 ms 1239.73 ms 11.91 ms
f8029e2 1245.16 ms 1261.32 ms 16.16 ms
99104c9 1224.84 ms 1247.08 ms 22.24 ms
0dd7283 1230.47 ms 1255.94 ms 25.47 ms
570f725 1206.00 ms 1238.96 ms 32.96 ms
7273bf4 1202.42 ms 1227.62 ms 25.21 ms
aa96485 1215.37 ms 1234.04 ms 18.67 ms
acac774 1217.76 ms 1253.29 ms 35.52 ms
2be5991 1228.55 ms 1264.65 ms 36.10 ms

App size

Revision Plain With Sentry Diff
56d2052 23.74 KiB 976.80 KiB 953.05 KiB
3c86ff3 23.75 KiB 919.69 KiB 895.94 KiB
f8029e2 23.75 KiB 893.72 KiB 869.97 KiB
99104c9 23.75 KiB 894.83 KiB 871.09 KiB
0dd7283 23.74 KiB 997.28 KiB 973.53 KiB
570f725 23.74 KiB 913.38 KiB 889.63 KiB
7273bf4 23.75 KiB 908.01 KiB 884.26 KiB
aa96485 23.75 KiB 874.46 KiB 850.71 KiB
acac774 23.75 KiB 866.51 KiB 842.76 KiB
2be5991 23.75 KiB 994.73 KiB 970.98 KiB

@noahsmartin noahsmartin merged commit 48f53bc into main Oct 16, 2025
182 of 186 checks passed
@noahsmartin noahsmartin deleted the beginMovingDependencies branch October 16, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ref: Begin moving dependencies to Swift

2 participants