-
-
Notifications
You must be signed in to change notification settings - Fork 366
ref: Begin moving dependencies to Swift #6442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
53fdb16
to
586de7a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6442 +/- ##
=============================================
+ Coverage 86.937% 86.957% +0.019%
=============================================
Files 447 448 +1
Lines 37582 37577 -5
Branches 17432 17437 +5
=============================================
+ Hits 32673 32676 +3
+ Misses 4867 4858 -9
- Partials 42 43 +1
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
586de7a
to
7cb2e5d
Compare
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
56d2052 | 1218.35 ms | 1247.58 ms | 29.23 ms |
3c86ff3 | 1227.82 ms | 1239.73 ms | 11.91 ms |
f8029e2 | 1245.16 ms | 1261.32 ms | 16.16 ms |
99104c9 | 1224.84 ms | 1247.08 ms | 22.24 ms |
0dd7283 | 1230.47 ms | 1255.94 ms | 25.47 ms |
570f725 | 1206.00 ms | 1238.96 ms | 32.96 ms |
7273bf4 | 1202.42 ms | 1227.62 ms | 25.21 ms |
aa96485 | 1215.37 ms | 1234.04 ms | 18.67 ms |
acac774 | 1217.76 ms | 1253.29 ms | 35.52 ms |
2be5991 | 1228.55 ms | 1264.65 ms | 36.10 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
56d2052 | 23.74 KiB | 976.80 KiB | 953.05 KiB |
3c86ff3 | 23.75 KiB | 919.69 KiB | 895.94 KiB |
f8029e2 | 23.75 KiB | 893.72 KiB | 869.97 KiB |
99104c9 | 23.75 KiB | 894.83 KiB | 871.09 KiB |
0dd7283 | 23.74 KiB | 997.28 KiB | 973.53 KiB |
570f725 | 23.74 KiB | 913.38 KiB | 889.63 KiB |
7273bf4 | 23.75 KiB | 908.01 KiB | 884.26 KiB |
aa96485 | 23.75 KiB | 874.46 KiB | 850.71 KiB |
acac774 | 23.75 KiB | 866.51 KiB | 842.76 KiB |
2be5991 | 23.75 KiB | 994.73 KiB | 970.98 KiB |
Now that we just have one type left to migrate before moving all of the dependency container to Swift, I started moving some of the easier ones into Swift here
#skip-changelog
Closes #6443