Skip to content

Conversation

itaybre
Copy link
Contributor

@itaybre itaybre commented Oct 17, 2025

Converts SentryFramesTracker to Swift as part of our Swift Conversion

Copy link

linear bot commented Oct 17, 2025

Copy link

codecov bot commented Oct 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.943%. Comparing base (dad3d69) to head (8955af5).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #6447       +/-   ##
=============================================
+ Coverage   86.706%   86.943%   +0.236%     
=============================================
  Files          449       449               
  Lines        37636     37728       +92     
  Branches     17449     17460       +11     
=============================================
+ Hits         32633     32802      +169     
+ Misses        4958      4882       -76     
+ Partials        45        44        -1     
Files with missing lines Coverage Δ
SentryTestUtils/TestDisplayLinkWrapper.swift 95.959% <100.000%> (ø)
SentryTestUtils/TestFramesTracker.swift 100.000% <ø> (ø)
Sources/Sentry/PrivateSentrySDKOnly.m 23.786% <ø> (ø)
...urces/Sentry/Profiling/SentryContinuousProfiler.mm 89.726% <100.000%> (-0.070%) ⬇️
...entry/Profiling/SentryProfiledTracerConcurrency.mm 90.661% <100.000%> (ø)
...ces/Sentry/Profiling/SentryProfilingSwiftHelpers.m 100.000% <100.000%> (ø)
Sources/Sentry/SentryANRTrackerV2.m 98.863% <ø> (ø)
Sources/Sentry/SentryAppStartTracker.m 95.394% <ø> (ø)
Sources/Sentry/SentryDependencyContainer.m 90.376% <100.000%> (+0.122%) ⬆️
Sources/Sentry/SentryFramesTrackingIntegration.m 100.000% <ø> (ø)
... and 5 more

... and 14 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dad3d69...8955af5. Read the comment docs.

Copy link
Contributor

github-actions bot commented Oct 17, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1229.50 ms 1263.58 ms 34.08 ms
Size 23.75 KiB 1016.89 KiB 993.15 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e446901 1233.32 ms 1252.32 ms 19.00 ms
7d88965 1228.86 ms 1248.53 ms 19.67 ms
354b020 1223.88 ms 1236.82 ms 12.94 ms
b5a7583 1238.22 ms 1263.94 ms 25.71 ms
efa740d 1220.71 ms 1246.20 ms 25.50 ms
3cdbc22 1231.63 ms 1251.06 ms 19.43 ms
ef2c9b3 1222.12 ms 1253.96 ms 31.84 ms
d7461dc 1233.69 ms 1255.29 ms 21.60 ms
162cd7f 1230.59 ms 1256.76 ms 26.16 ms
3067c23 1230.48 ms 1257.90 ms 27.42 ms

App size

Revision Plain With Sentry Diff
e446901 23.75 KiB 933.33 KiB 909.58 KiB
7d88965 23.75 KiB 994.72 KiB 970.98 KiB
354b020 23.75 KiB 878.19 KiB 854.44 KiB
b5a7583 23.75 KiB 913.44 KiB 889.68 KiB
efa740d 23.75 KiB 919.69 KiB 895.95 KiB
3cdbc22 23.75 KiB 928.14 KiB 904.40 KiB
ef2c9b3 23.75 KiB 933.03 KiB 909.29 KiB
d7461dc 23.75 KiB 874.45 KiB 850.70 KiB
162cd7f 23.75 KiB 908.39 KiB 884.64 KiB
3067c23 23.75 KiB 928.15 KiB 904.40 KiB

Previous results on branch: itay/cocoa-710-convert-sentryframestracker

Startup times

Revision Plain With Sentry Diff
3d97815 1219.19 ms 1252.28 ms 33.09 ms

App size

Revision Plain With Sentry Diff
3d97815 23.75 KiB 1015.77 KiB 992.02 KiB

@itaybre itaybre merged commit 94de2d3 into main Oct 17, 2025
199 of 201 checks passed
@itaybre itaybre deleted the itay/cocoa-710-convert-sentryframestracker branch October 17, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants