feat(web): load injected debug ids #2917
Open
+328
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2917 +/- ##
==========================================
+ Coverage 87.63% 89.23% +1.60%
==========================================
Files 272 93 -179
Lines 9047 3083 -5964
==========================================
- Hits 7928 2751 -5177
+ Misses 1119 332 -787 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Android Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f7f46dc | 306.38 ms | 363.32 ms | 56.95 ms |
| b56b25c | 438.09 ms | 563.34 ms | 125.25 ms |
| a775d3f | 359.58 ms | 436.68 ms | 77.10 ms |
| c70e01a | 331.04 ms | 401.46 ms | 70.42 ms |
| 84c28cd | 415.11 ms | 549.44 ms | 134.33 ms |
| 547db82 | 453.40 ms | 482.88 ms | 29.48 ms |
| ca9f398 | 476.88 ms | 518.38 ms | 41.50 ms |
| 21d4150 | 379.31 ms | 449.23 ms | 69.93 ms |
| d1488a1 | 516.78 ms | 585.04 ms | 68.27 ms |
| b39b48c | 474.21 ms | 529.62 ms | 55.41 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f7f46dc | 6.06 MiB | 7.03 MiB | 993.54 KiB |
| b56b25c | 6.46 MiB | 7.48 MiB | 1.02 MiB |
| a775d3f | 6.27 MiB | 7.20 MiB | 957.75 KiB |
| c70e01a | 5.94 MiB | 6.97 MiB | 1.03 MiB |
| 84c28cd | 6.49 MiB | 7.56 MiB | 1.07 MiB |
| 547db82 | 6.49 MiB | 7.56 MiB | 1.07 MiB |
| ca9f398 | 6.49 MiB | 7.56 MiB | 1.07 MiB |
| 21d4150 | 5.94 MiB | 6.97 MiB | 1.03 MiB |
| d1488a1 | 6.46 MiB | 7.48 MiB | 1.03 MiB |
| b39b48c | 6.46 MiB | 7.48 MiB | 1.02 MiB |
Previous results on branch: feat-web/debug-id
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3a7db1a | 446.35 ms | 512.92 ms | 66.57 ms |
| 6142497 | 483.55 ms | 511.39 ms | 27.84 ms |
| f5e3a89 | 461.40 ms | 485.04 ms | 23.64 ms |
| 6d0e7e1 | 448.24 ms | 492.21 ms | 43.97 ms |
| 210c451 | 387.11 ms | 422.44 ms | 35.33 ms |
| 68284ff | 440.50 ms | 499.02 ms | 58.52 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3a7db1a | 6.44 MiB | 7.43 MiB | 1013.66 KiB |
| 6142497 | 6.44 MiB | 7.43 MiB | 1013.14 KiB |
| f5e3a89 | 6.44 MiB | 7.43 MiB | 1013.65 KiB |
| 6d0e7e1 | 6.44 MiB | 7.43 MiB | 1013.66 KiB |
| 210c451 | 6.44 MiB | 7.43 MiB | 1013.65 KiB |
| 68284ff | 6.44 MiB | 7.43 MiB | 1013.65 KiB |
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5e8d2b3 | 1255.71 ms | 1267.98 ms | 12.27 ms |
| 051e97a | 1245.94 ms | 1249.51 ms | 3.57 ms |
| 07cd9e8 | 1237.04 ms | 1257.50 ms | 20.46 ms |
| 7fd33d3 | 1241.92 ms | 1265.47 ms | 23.55 ms |
| a24a1db | 1257.71 ms | 1271.57 ms | 13.87 ms |
| 5aa047a | 1236.57 ms | 1241.02 ms | 4.45 ms |
| abfcdb5 | 1230.87 ms | 1244.94 ms | 14.06 ms |
| 7659cbe | 1246.70 ms | 1265.88 ms | 19.17 ms |
| 4d046e0 | 1243.08 ms | 1255.98 ms | 12.90 ms |
| bd1b990 | 1209.43 ms | 1226.96 ms | 17.53 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5e8d2b3 | 8.29 MiB | 9.36 MiB | 1.07 MiB |
| 051e97a | 8.28 MiB | 9.34 MiB | 1.06 MiB |
| 07cd9e8 | 8.38 MiB | 9.77 MiB | 1.40 MiB |
| 7fd33d3 | 8.38 MiB | 9.78 MiB | 1.40 MiB |
| a24a1db | 8.42 MiB | 9.91 MiB | 1.49 MiB |
| 5aa047a | 8.29 MiB | 9.39 MiB | 1.10 MiB |
| abfcdb5 | 8.33 MiB | 9.64 MiB | 1.31 MiB |
| 7659cbe | 8.42 MiB | 9.89 MiB | 1.47 MiB |
| 4d046e0 | 8.42 MiB | 9.83 MiB | 1.40 MiB |
| bd1b990 | 8.32 MiB | 9.38 MiB | 1.06 MiB |
Previous results on branch: feat-web/debug-id
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 68284ff | 1257.16 ms | 1279.12 ms | 21.96 ms |
| 3a7db1a | 1275.20 ms | 1287.49 ms | 12.29 ms |
| 6d0e7e1 | 1254.73 ms | 1261.14 ms | 6.41 ms |
| 6142497 | 1252.72 ms | 1267.91 ms | 15.20 ms |
| f5e3a89 | 1246.09 ms | 1261.11 ms | 15.02 ms |
| 210c451 | 1264.82 ms | 1273.73 ms | 8.91 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 68284ff | 8.43 MiB | 10.01 MiB | 1.58 MiB |
| 3a7db1a | 8.43 MiB | 10.01 MiB | 1.58 MiB |
| 6d0e7e1 | 8.43 MiB | 10.01 MiB | 1.58 MiB |
| 6142497 | 8.43 MiB | 10.01 MiB | 1.58 MiB |
| f5e3a89 | 8.43 MiB | 10.01 MiB | 1.58 MiB |
| 210c451 | 8.43 MiB | 10.01 MiB | 1.58 MiB |
denrase
requested changes
May 12, 2025
denrase
approved these changes
May 13, 2025
|
This PR will stay open until the dart plugin is released with debug id support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Adds debug id support in Flutter Web
💡 Motivation and Context
Symbolication via release/dist association is not stable enough, hard to use and confusing.
Using debug-ids makes it automatically much easier.
💚 How did you test it?
Manual test, unit test
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps