Skip to content

Sentry Structured Logs #2919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Sentry Structured Logs #2919

wants to merge 5 commits into from

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented May 7, 2025

📜 Description

💡 Motivation and Context

Closes #2915

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

Copy link
Contributor

github-actions bot commented May 7, 2025

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Sentry Structured Logs ([#2919](https://github.com/getsentry/sentry-dart/pull/2919))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against d14ba16

Copy link

codecov bot commented May 7, 2025

Codecov Report

Attention: Patch coverage is 97.67442% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.72%. Comparing base (bc3ad3c) to head (2b265e7).

Files with missing lines Patch % Lines
dart/lib/src/noop_log_batcher.dart 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2919      +/-   ##
==========================================
+ Coverage   87.63%   87.72%   +0.09%     
==========================================
  Files         272      277       +5     
  Lines        9047     9133      +86     
==========================================
+ Hits         7928     8012      +84     
- Misses       1119     1121       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

github-actions bot commented May 7, 2025

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1255.86 ms 1266.10 ms 10.24 ms
Size 8.43 MiB 10.02 MiB 1.58 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
67a5716 1236.41 ms 1256.70 ms 20.29 ms
2261c15 1249.49 ms 1259.69 ms 10.20 ms
1e781fc 1257.96 ms 1281.49 ms 23.53 ms
2331d89 1260.86 ms 1281.24 ms 20.39 ms
6d50a9b 1225.69 ms 1233.94 ms 8.25 ms
40daa7b 1244.13 ms 1263.84 ms 19.71 ms
9811573 1259.78 ms 1278.33 ms 18.55 ms
d10745a 1251.29 ms 1268.71 ms 17.43 ms
21562c5 1235.43 ms 1254.00 ms 18.57 ms
6e9c5a2 1245.59 ms 1260.24 ms 14.65 ms

App size

Revision Plain With Sentry Diff
67a5716 8.42 MiB 9.91 MiB 1.49 MiB
2261c15 8.28 MiB 9.34 MiB 1.06 MiB
1e781fc 8.10 MiB 9.18 MiB 1.08 MiB
2331d89 8.16 MiB 9.17 MiB 1.01 MiB
6d50a9b 8.38 MiB 9.74 MiB 1.36 MiB
40daa7b 8.42 MiB 9.97 MiB 1.55 MiB
9811573 8.16 MiB 9.17 MiB 1.01 MiB
d10745a 8.28 MiB 9.33 MiB 1.05 MiB
21562c5 8.29 MiB 9.36 MiB 1.07 MiB
6e9c5a2 8.34 MiB 9.66 MiB 1.31 MiB

Previous results on branch: feat/logs

Startup times

Revision Plain With Sentry Diff
2b265e7 1252.19 ms 1268.96 ms 16.77 ms

App size

Revision Plain With Sentry Diff
2b265e7 8.43 MiB 10.02 MiB 1.58 MiB

@denrase denrase mentioned this pull request May 8, 2025
6 tasks
Copy link
Contributor

github-actions bot commented May 13, 2025

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 515.76 ms 585.18 ms 69.42 ms
Size 6.44 MiB 7.43 MiB 1014.13 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
8f95e33 444.80 ms 493.21 ms 48.42 ms
0ceb89c 304.57 ms 357.18 ms 52.61 ms
b2cbbc8 347.80 ms 395.31 ms 47.51 ms
a4c4f8c 349.71 ms 414.12 ms 64.41 ms
9555112 448.81 ms 488.89 ms 40.08 ms
1b0c8a3 479.78 ms 521.18 ms 41.40 ms
3adbea9 395.16 ms 447.88 ms 52.71 ms
d0312c9 354.78 ms 411.53 ms 56.75 ms
abcdba3 354.68 ms 399.04 ms 44.36 ms
c73ab67 353.82 ms 408.71 ms 54.90 ms

App size

Revision Plain With Sentry Diff
8f95e33 6.49 MiB 7.57 MiB 1.08 MiB
0ceb89c 5.94 MiB 6.95 MiB 1.01 MiB
b2cbbc8 6.06 MiB 7.03 MiB 995.45 KiB
a4c4f8c 6.49 MiB 7.56 MiB 1.07 MiB
9555112 6.52 MiB 7.59 MiB 1.06 MiB
1b0c8a3 6.49 MiB 7.57 MiB 1.08 MiB
3adbea9 6.52 MiB 7.61 MiB 1.09 MiB
d0312c9 6.33 MiB 7.26 MiB 949.76 KiB
abcdba3 5.94 MiB 6.95 MiB 1.01 MiB
c73ab67 6.15 MiB 7.13 MiB 999.97 KiB

Previous results on branch: feat/logs

Startup times

Revision Plain With Sentry Diff
2b265e7 454.83 ms 537.04 ms 82.21 ms

App size

Revision Plain With Sentry Diff
2b265e7 6.44 MiB 7.43 MiB 1011.23 KiB

CHANGELOG.md Outdated
Comment on lines 7 to 9
- Logs: Models & Envelopes ([#2916](https://github.com/getsentry/sentry-dart/pull/2916))
- Logs: Integrate in Sentry Client ([#2920](https://github.com/getsentry/sentry-dart/pull/2920))
- [Structured Logs]: Buffering and Flushing of Logs ([#2930](https://github.com/getsentry/sentry-dart/pull/2930))
Copy link
Contributor

@buenaflor buenaflor May 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's unify the changelog entry and reference this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sentry Structured Logs for Dart/Flutter
2 participants