-
-
Notifications
You must be signed in to change notification settings - Fork 255
Sentry Structured Logs #2919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Sentry Structured Logs #2919
Conversation
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Sentry Structured Logs ([#2919](https://github.com/getsentry/sentry-dart/pull/2919)) If none of the above apply, you can opt out of this check by adding |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2919 +/- ##
==========================================
+ Coverage 87.63% 87.72% +0.09%
==========================================
Files 272 277 +5
Lines 9047 9133 +86
==========================================
+ Hits 7928 8012 +84
- Misses 1119 1121 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
iOS Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
67a5716 | 1236.41 ms | 1256.70 ms | 20.29 ms |
2261c15 | 1249.49 ms | 1259.69 ms | 10.20 ms |
1e781fc | 1257.96 ms | 1281.49 ms | 23.53 ms |
2331d89 | 1260.86 ms | 1281.24 ms | 20.39 ms |
6d50a9b | 1225.69 ms | 1233.94 ms | 8.25 ms |
40daa7b | 1244.13 ms | 1263.84 ms | 19.71 ms |
9811573 | 1259.78 ms | 1278.33 ms | 18.55 ms |
d10745a | 1251.29 ms | 1268.71 ms | 17.43 ms |
21562c5 | 1235.43 ms | 1254.00 ms | 18.57 ms |
6e9c5a2 | 1245.59 ms | 1260.24 ms | 14.65 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
67a5716 | 8.42 MiB | 9.91 MiB | 1.49 MiB |
2261c15 | 8.28 MiB | 9.34 MiB | 1.06 MiB |
1e781fc | 8.10 MiB | 9.18 MiB | 1.08 MiB |
2331d89 | 8.16 MiB | 9.17 MiB | 1.01 MiB |
6d50a9b | 8.38 MiB | 9.74 MiB | 1.36 MiB |
40daa7b | 8.42 MiB | 9.97 MiB | 1.55 MiB |
9811573 | 8.16 MiB | 9.17 MiB | 1.01 MiB |
d10745a | 8.28 MiB | 9.33 MiB | 1.05 MiB |
21562c5 | 8.29 MiB | 9.36 MiB | 1.07 MiB |
6e9c5a2 | 8.34 MiB | 9.66 MiB | 1.31 MiB |
Android Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
8f95e33 | 444.80 ms | 493.21 ms | 48.42 ms |
0ceb89c | 304.57 ms | 357.18 ms | 52.61 ms |
b2cbbc8 | 347.80 ms | 395.31 ms | 47.51 ms |
a4c4f8c | 349.71 ms | 414.12 ms | 64.41 ms |
9555112 | 448.81 ms | 488.89 ms | 40.08 ms |
1b0c8a3 | 479.78 ms | 521.18 ms | 41.40 ms |
3adbea9 | 395.16 ms | 447.88 ms | 52.71 ms |
d0312c9 | 354.78 ms | 411.53 ms | 56.75 ms |
abcdba3 | 354.68 ms | 399.04 ms | 44.36 ms |
c73ab67 | 353.82 ms | 408.71 ms | 54.90 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
8f95e33 | 6.49 MiB | 7.57 MiB | 1.08 MiB |
0ceb89c | 5.94 MiB | 6.95 MiB | 1.01 MiB |
b2cbbc8 | 6.06 MiB | 7.03 MiB | 995.45 KiB |
a4c4f8c | 6.49 MiB | 7.56 MiB | 1.07 MiB |
9555112 | 6.52 MiB | 7.59 MiB | 1.06 MiB |
1b0c8a3 | 6.49 MiB | 7.57 MiB | 1.08 MiB |
3adbea9 | 6.52 MiB | 7.61 MiB | 1.09 MiB |
d0312c9 | 6.33 MiB | 7.26 MiB | 949.76 KiB |
abcdba3 | 5.94 MiB | 6.95 MiB | 1.01 MiB |
c73ab67 | 6.15 MiB | 7.13 MiB | 999.97 KiB |
# Conflicts: # flutter/example/lib/main.dart
CHANGELOG.md
Outdated
- Logs: Models & Envelopes ([#2916](https://github.com/getsentry/sentry-dart/pull/2916)) | ||
- Logs: Integrate in Sentry Client ([#2920](https://github.com/getsentry/sentry-dart/pull/2920)) | ||
- [Structured Logs]: Buffering and Flushing of Logs ([#2930](https://github.com/getsentry/sentry-dart/pull/2930)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's unify the changelog entry and reference this issue
📜 Description
itemCount
toSentryEnvelopeItemHeader
sentry-cocoa#5230💡 Motivation and Context
Closes #2915
💚 How did you test it?
📝 Checklist
sendDefaultPii
is enabled