-
-
Notifications
You must be signed in to change notification settings - Fork 275
Refactor: move native breadcrumbs sync to FFI/JNI #3293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: enh/app-hang-ffi-jni-refactor
Are you sure you want to change the base?
Refactor: move native breadcrumbs sync to FFI/JNI #3293
Conversation
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## enh/app-hang-ffi-jni-refactor #3293 +/- ##
=================================================================
- Coverage 88.65% 88.50% -0.15%
=================================================================
Files 99 99
Lines 3534 3523 -11
=================================================================
- Hits 3133 3118 -15
- Misses 401 405 +4 ☔ View full report in Codecov by Sentry. |
packages/flutter/ios/sentry_flutter/Sources/sentry_flutter/SentryFlutterPlugin.swift
Outdated
Show resolved
Hide resolved
val reader = JsonObjectReader(StringReader(breadcrumbJson)) | ||
val breadcrumb = Breadcrumb.Deserializer().deserialize(reader, logger) | ||
Sentry.addBreadcrumb(breadcrumb) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📜 Description
Part of FFI/JNI refactorings
💡 Motivation and Context
Partly completes #3204
💚 How did you test it?
Manual tests, integration test
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps