Skip to content

ci(release): Switch from action-prepare-release to Craft #3440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BYK wants to merge 51 commits into
base: main
Choose a base branch
from
+25 −3
Open

ci(release): Switch from action-prepare-release to Craft #3440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
ee4e7c7
ci(release): Switch from action-prepare-release to Craft
BYK Jan 9, 2026
486e197
ci(release): Restore GitHub App token authentication
BYK Jan 9, 2026
915ad33
fix: Pin actions to SHA and add permissions blocks
BYK Jan 10, 2026
da9b49f
fix: Use correct action version SHAs (restore original versions)
BYK Jan 10, 2026
94ea76f
fix: Use correct action version SHAs (restore original versions)
BYK Jan 10, 2026
5e3c97a
fix: Clean up action version comments
BYK Jan 12, 2026
c10928f
Update Craft SHA to 1c58bfd57bfd6a967b6f3fc92bead2c42ee698ce
BYK Jan 13, 2026
6cca9f5
Add explicit permissions block to analyze.yml
BYK Jan 13, 2026
cb7a3c0
Add explicit permissions block to dart.yml
BYK Jan 13, 2026
93d76a3
Add explicit permissions block to dio.yml
BYK Jan 13, 2026
068fb81
Add explicit permissions block to drift.yml
BYK Jan 13, 2026
49523f4
Add explicit permissions block to e2e_dart.yml
BYK Jan 13, 2026
46d0cda
Add explicit permissions block to file.yml
BYK Jan 13, 2026
51c28f0
Add explicit permissions block to firebase_remote_config.yml
BYK Jan 13, 2026
d98598f
Add explicit permissions block to flutter.yml
BYK Jan 13, 2026
5913dd1
Add explicit permissions block to flutter_test.yml
BYK Jan 13, 2026
c4b6e0f
Add explicit permissions block to format-and-fix.yml
BYK Jan 13, 2026
601ef8d
Add explicit permissions block to hive.yml
BYK Jan 13, 2026
3ab8c18
Add explicit permissions block to isar.yml
BYK Jan 13, 2026
0729237
Add explicit permissions block to link.yml
BYK Jan 13, 2026
c0e9dc3
Add explicit permissions block to logging.yml
BYK Jan 13, 2026
928e9a5
Add explicit permissions block to metrics.yml
BYK Jan 13, 2026
bd2aa0f
Add explicit permissions block to min_version_test.yml
BYK Jan 13, 2026
fac7650
Add explicit permissions block to sqflite.yml
BYK Jan 13, 2026
556682f
Add explicit permissions block to supabase.yml
BYK Jan 13, 2026
c67b543
Add explicit permissions block to testflight.yml
BYK Jan 13, 2026
0c213db
Add explicit permissions block to web-example-ghpages.yml
BYK Jan 13, 2026
493c0b6
Revert permissions changes to analyze.yml
BYK Jan 13, 2026
1460e67
Revert permissions changes to dart.yml
BYK Jan 13, 2026
65e1708
Revert permissions changes to dio.yml
BYK Jan 13, 2026
4f5ca5f
Revert permissions changes to drift.yml
BYK Jan 13, 2026
a9fb284
Revert permissions changes to e2e_dart.yml
BYK Jan 13, 2026
df7d5e9
Revert permissions changes to file.yml
BYK Jan 13, 2026
97e42a9
Revert permissions changes to firebase_remote_config.yml
BYK Jan 13, 2026
9790035
Revert permissions changes to flutter.yml
BYK Jan 13, 2026
fce1b14
Revert permissions changes to flutter_test.yml
BYK Jan 13, 2026
51467ab
Revert permissions changes to format-and-fix.yml
BYK Jan 13, 2026
099b4fc
Revert permissions changes to hive.yml
BYK Jan 13, 2026
88598fc
Revert permissions changes to isar.yml
BYK Jan 13, 2026
4a85db8
Revert permissions changes to link.yml
BYK Jan 13, 2026
7869a62
Revert permissions changes to logging.yml
BYK Jan 13, 2026
6a91a9b
Revert permissions changes to metrics.yml
BYK Jan 13, 2026
c75f162
Revert permissions changes to min_version_test.yml
BYK Jan 13, 2026
a450fb7
Revert permissions changes to sqflite.yml
BYK Jan 13, 2026
6daf668
Revert permissions changes to supabase.yml
BYK Jan 13, 2026
db8876c
Revert permissions changes to testflight.yml
BYK Jan 13, 2026
a6a4059
Revert permissions changes to web-example-ghpages.yml
BYK Jan 13, 2026
e2641dc
fix: revert extraneous changes to non-release workflow files
BYK Jan 14, 2026
4e1e223
fix: clean up release.yml formatting and version comments
BYK Jan 14, 2026
9c0df90
build(craft): Update Craft action to c6e2f04
BYK Jan 14, 2026
37107ff
chore: add unlabeled trigger to changelog-preview
BYK Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .github/workflows/changelog-preview.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
name: Changelog Preview
on:
pull_request:
types:
- opened
- synchronize
- reopened
- edited
- labeled
- unlabeled
permissions:
contents: write
pull-requests: write

jobs:
changelog-preview:
uses: getsentry/craft/.github/workflows/changelog-preview.yml@v2
secrets: inherit
10 changes: 7 additions & 3 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,19 @@ on:
workflow_dispatch:
inputs:
version:
description: Version to release
required: true
description: Version to release (or "auto")
required: false
force:
description: Force a release even when there are release-blockers (optional)
required: false
merge_target:
description: Target branch to merge into. Uses the default branch as a fallback (optional)
required: false

permissions:
contents: write
pull-requests: write

jobs:
release:
runs-on: ubuntu-latest
Expand All @@ -29,7 +33,7 @@ jobs:
token: ${{ steps.token.outputs.token }}
fetch-depth: 0
- name: Prepare release
uses: getsentry/action-prepare-release@c8e1c2009ab08259029170132c384f03c1064c0e
uses: getsentry/craft@c6e2f04939b6ee67030588afbb5af76b127d8203 # v2
env:
GITHUB_TOKEN: ${{ steps.token.outputs.token }}
Copy link

@sentry sentry bot Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The release workflow will fail if the optional version input is not provided, as it passes an empty string to Craft which causes a validation error.
Severity: CRITICAL

Suggested Fix

To align with the intended behavior of defaulting to auto-versioning, modify the version parameter to handle an empty string. Change the line to version: ${{ github.event.inputs.version || 'auto' }}. This will ensure that if no version is supplied, 'auto' is passed to Craft instead of an empty string.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: .github/workflows/release.yml#L38

Potential issue: The `release.yml` workflow was updated to make the `version` input
optional. When a user triggers this workflow via `workflow_dispatch` without providing a
version, GitHub Actions passes an empty string (`""`) for `github.event.inputs.version`.
This empty string is then passed directly to the Craft action. As evidenced by a past
incident ([Sentry issue #88068](https://sentry-st.sentry.io/issues/88068)), Craft will
reject an empty string with a validation error, causing the entire release workflow to
fail. This prevents releases when the supposedly optional version is omitted.

Did we get this right? 👍 / 👎 to inform future reviews.

with:
Expand Down