Skip to content

refactor(log): make implementation consistent with metrics and span-first #3463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
buenaflor wants to merge 7 commits into
base: feat/metrics
Choose a base branch
from
Draft

refactor(log): make implementation consistent with metrics and span-first #3463

buenaflor wants to merge 7 commits into from

Conversation

@buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Jan 20, 2026 •
edited
Loading

📜 Description

Refactor the implementations to use the new abstractions

  • Add new capture pipeline
  • Use OnProcessLog instead of OnBeforeCaptureLog for the attribute enrichments
  • Remove LogsEnricherIntegration -> moved to defaultAttributes

💚 How did you test it?

Manual and unit tests

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

buenaflor and others added 5 commits January 20, 2026 18:06
@buenaflor
Refactor logging integration by replacing LogsEnricherIntegration wit…
756de8a 
…h a new logging pipeline and default logger implementation. Update related tests and remove deprecated code.
@buenaflor
Enhance logging tests by adding timestamp verification and attribute …
1f2dc29 
…inclusion checks. Simplify test case formatting for clarity.
@buenaflor
Refactor SentryLog constructor to require traceId and adjust spanId i…
25b0de7 
…nitialization. Remove outdated comment for clarity.
@buenaflor
Merge branch 'feat/metrics' into ref/log-capture-pipeline
98bdb7a
@buenaflor
Refactor logger tests to improve readability by formatting logger.inf…
0919930 
…o calls. Add traceId initialization to SentryLog in processing tests for consistency.
@buenaflor
Copy link
Contributor Author

buenaflor commented Jan 20, 2026

bugbot review

@buenaflor
Remove deprecated test for LogsEnricherIntegration from load_contexts…
5055a7e 
…_integration_test.dart to streamline logger tests.
@buenaflor
Remove unused import for LogsEnricherIntegration in load_contexts_int…
d253868 
…egration_test.dart to clean up the test file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@denrase denrase Awaiting requested review from denrase denrase will be requested when the pull request is marked ready for review denrase is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@buenaflor