Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(nuxt): drop duplicate browser tracing integration #12361

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

dargmuesli
Copy link
Contributor

DESCRIBE YOUR PR

It appears the browser tracing integration is automatically configured for Nuxt: https://github.com/getsentry/sentry-javascript/blob/e59055092c546274eb3767da56ec32944f14b075/packages/nuxt/src/runtime/plugins/sentry.client.ts#L45

I think it's enough to configure tracePropagationTargets, but please correct me if I'm wrong.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

It appears the browser tracing integration is automatically configured for Nuxt: https://github.com/getsentry/sentry-javascript/blob/e59055092c546274eb3767da56ec32944f14b075/packages/nuxt/src/runtime/plugins/sentry.client.ts#L45

I think it's enough to configure `tracePropagationTargets`, but please correct me if I'm wrong.
Copy link

vercel bot commented Jan 15, 2025

@dargmuesli is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

@coolguyzone coolguyzone requested a review from s1gr1d January 16, 2025 18:57
Copy link

vercel bot commented Jan 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 20, 2025 3:16pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Jan 20, 2025 3:16pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Jan 20, 2025 3:16pm

@s1gr1d s1gr1d merged commit 099cf7a into getsentry:master Jan 20, 2025
11 checks passed
@dargmuesli dargmuesli deleted the patch-4 branch January 20, 2025 19:10
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants