-
-
Notifications
You must be signed in to change notification settings - Fork 220
Added CaptureFeedback overload with configureScope parameter #4073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
question: For which types "should" we add unit tests?
We should then also add missing tests for the equivalent We could also extract this comment to a new issue, and complete the test coverage separately, should this bloat or conflate the scope of this PR. (I'm happy to submit that as my first changeset 😉) |
I'd rather have the unit tests included in the PR that they relate to. Otherwise it becomes really easy for us to adopt a "build now test Normally I'd say since I wrote the code, I should be adding the unit tests (and reviewers like yourself should be insisting I do so). But if you want to make some first commits, you're welcome to add some unit tests to this PR and we can share the glory.
You'll see examples of tests for all of the others though: |
Resolves #4035: