Skip to content

[Mobile Vitals] Time-to-initial-display & initial concept for time-to-full-display #4088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

aritchie
Copy link
Collaborator

@aritchie aritchie commented Apr 7, 2025

This adds a bunch of additional needed points

  • Finish(DateTimeOffset) added to ISpan members. Marked as default nullable to prevent breaking signature
  • event StatusChanged for ISpan to allow monitoring of all spans to await finish
  • Adds a default DateTimeOffset for setting startTimestamp on through ISentryClient and span ctors
  • A new MAUI extension point in IMauiPageEventHandler
    • This may be marked as internal since I don't think we should open this up to external users
    • I wanted to separate this from IMauiElementEventBinder since it has several different hooks I wanted to watch

There are a few TODOs on this, but I wanted to get this in for initial thoughts

TODO

  • Unit Tests
  • Feature Flag?
  • Additional logic for TTFD

Copy link
Contributor

github-actions bot commented Apr 7, 2025

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- [Mobile Vitals] Time-to-initial-display & initial concept for time-to-full-display ([#4088](https://github.com/getsentry/sentry-dotnet/pull/4088))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 9bfed02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants