Skip to content

Build Variables Source Generator #4101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Build Variables Source Generator #4101

wants to merge 7 commits into from

Conversation

aritchie
Copy link
Collaborator

Resolves #2927

This is the initial implementation of proposed AOT build checks

Features

  • Generates a precompiled list of msbuild properties we were interested in based on various issues within our repo
  • Currently, we only look at PublishTrimmed and PublishAot in our AotHelper
  • Generates module initializer only on runnable targets
  • Ability to disable source generator if user encounters issue

TODO

  • Unit Tests
  • Document ability to disable source generator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamescrosswell jamescrosswell Awaiting requested review from jamescrosswell jamescrosswell will be requested when the pull request is marked ready for review jamescrosswell is a code owner

@Flash0ver Flash0ver Awaiting requested review from Flash0ver Flash0ver will be requested when the pull request is marked ready for review Flash0ver is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate AotHelper properties at compile time
3 participants
@aritchie @getsentry-bot @jamescrosswell