Skip to content

work around iOS SHA1 bug #4143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 27, 2025
Merged

work around iOS SHA1 bug #4143

merged 3 commits into from
Apr 27, 2025

Conversation

bruno-garcia
Copy link
Member

@bruno-garcia bruno-garcia commented Apr 25, 2025

@jamescrosswell jamescrosswell requested a review from aritchie April 27, 2025 01:07
@jamescrosswell
Copy link
Collaborator

Overall, this looks good. We do have another reference to GetHashString here (which, ironically, is commented with Never fails):

// Never fails
Environment.MachineName.GetHashString();

It's a secondary fallback that's used here:

var id =
TryGetPersistentInstallationId() ??
TryGetHardwareInstallationId() ??
GetMachineNameInstallationId();

So that code only executes if we fail to obtain either a persistent or a hardware id.

I don't think that should block this PR... but if we continue to have issues, I can't see an easy way around that one short of rolling out our own hashing function.

@jamescrosswell jamescrosswell merged commit a04a10a into main Apr 27, 2025
19 checks passed
@jamescrosswell jamescrosswell deleted the bruno-garcia-patch-1 branch April 27, 2025 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants