fix: Builds failing intermittently on Windows #4146
Merged
+12
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4091:
Explanation
Previously we had this build target in
Sentry.Android.AssemblyReader.Tests.csproj
:sentry-dotnet/test/Sentry.Android.AssemblyReader.Tests/Sentry.Android.AssemblyReader.Tests.csproj
Lines 19 to 24 in a04a10a
It was building for both the net8.0-android and net9.0-android targets... however it also gets called for both the net8.0 and net9.0 TFMs for
Sentry.Android.AssemblyReader.Tests.csproj
. So essentially it's duplicated and sometimes on Windows that results in two instances of the task trying to write to the same files - leading to a permission denied error.#skip-changelog