Do not push a new scope on StartSpan
#1013
Merged
+14
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially reverts #886 and fixes #1009.
Pushing a new scope on each new span has too many side effects, like making it impossible to access the "root" scope to attach certain attributes like the user to it.
Instead, we now only set the span on the scope when it's started and set it back to its parent when it finishes.
As it's a hard requirement to always clone the hub when working with go routines, we now have a simulated isolation scope.
Parent child relations are correctly maintained with this changes, as well as error -> span correlation.