Fix otel span being created as a transaction #1073
Merged
+147
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #669. The bug arises from early cleanup logic on the sentry span map. A span can finish before it's child starts, and then the span would be already deleted with the current implementation.
Introducing smarted cleanup, to actually keep track of finished spans on a tree and cleanup only if the whole subtree is finished, to actually correctly link the spans.