-
Notifications
You must be signed in to change notification settings - Fork 241
feat: properly support error capturing #1075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1075 +/- ##
==========================================
- Coverage 87.00% 86.93% -0.07%
==========================================
Files 55 57 +2
Lines 6077 6132 +55
==========================================
+ Hits 5287 5331 +44
- Misses 645 653 +8
- Partials 145 148 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2b77a8e
to
e852a0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for bearing with me.
Left some more nits that you can also disregard.
Issue Grouping changes should be documented in the changelog.
02fd170
to
533a87d
Compare
Description
This PR adds support for capturing all possible errors (including wrapped ones) in Go. The following changes were made:
Unwrap() []error
interface, by parsing all errors in a dfs-like traversal.is_exception_group
. In the end made the decision to only captureUnwrap() []error
errors as exception_groups. This breaks the previous behavior of including any chained error in a group.Cause() error
.maxErrorDepth
For the change to the default after a quick investigation these are some rough payload sizes based on the amount of errors that get unwrapped. Setting it to 100 since the payload sizes are not that big to cause any issues.
Built-in errors
Third-party pkg/errors
Issues
errors.Join
errors inSetException
#977.