Skip to content

Conversation

giortzisg
Copy link
Contributor

Description

Add generic ring buffer implementation with metrics functionality.

Issues

@giortzisg giortzisg requested a review from cleptric September 24, 2025 11:08
Copy link

linear bot commented Sep 24, 2025

Copy link

codecov bot commented Sep 24, 2025

Codecov Report

❌ Patch coverage is 87.41007% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.98%. Comparing base (2dc3b97) to head (193c8ad).

Files with missing lines Patch % Lines
internal/telemetry/buffer.go 86.11% 28 Missing and 7 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1093      +/-   ##
==========================================
- Coverage   86.99%   86.98%   -0.01%     
==========================================
  Files          55       57       +2     
  Lines        6076     6356     +280     
==========================================
+ Hits         5286     5529     +243     
- Misses        645      675      +30     
- Partials      145      152       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

cursor[bot]

This comment was marked as outdated.

Copy link
Member

@sl0thentr0py sl0thentr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initial comment about the DataCategory, will review buffer in a bit

@sl0thentr0py
Copy link
Member

buffer itself lgtm, nice work!

@giortzisg giortzisg requested a review from sl0thentr0py October 6, 2025 15:00
cursor[bot]

This comment was marked as outdated.

@lcian lcian self-requested a review October 9, 2025 11:46
Copy link
Member

@lcian lcian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement generic transport buffers

3 participants