-
Notifications
You must be signed in to change notification settings - Fork 242
ref: create debuglog package #1105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1105 +/- ##
==========================================
- Coverage 86.98% 86.92% -0.06%
==========================================
Files 54 56 +2
Lines 6068 6080 +12
==========================================
+ Hits 5278 5285 +7
- Misses 645 649 +4
- Partials 145 146 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in principle and I understand the problem this solves.
I think it's a bit unfortunate that we have to lock on every message, and I wonder if there's a different way to do it without locking.
Anyways, I would assume that customers don't enable Debug: true
in production, so it shouldn't be a big deal in practice.
@lcian We can actually remove the mutex locks by removing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Description
Create a
debuglog
package to easily access thesentry.DebugLogger
without depending on the root level. This change aims to remove any cyclic imports when internal packages are used on the top level, but also want to access the debug logger.Issues