-
Notifications
You must be signed in to change notification settings - Fork 229
Implement flush with context #935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #935 +/- ##
==========================================
- Coverage 85.47% 85.33% -0.15%
==========================================
Files 55 55
Lines 5486 5515 +29
==========================================
+ Hits 4689 4706 +17
- Misses 653 663 +10
- Partials 144 146 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The only thing failing here is the coverage. Do I have to 'fix' it or we can merge as-is? |
Do we have docs for this? |
No. Should I add it in |
Yes |
Co-authored-by: Michi Hoffmann <[email protected]>
Resolves #746