Skip to content

Implement flush with context #935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Implement flush with context #935

wants to merge 18 commits into from

Conversation

ribice
Copy link
Collaborator

@ribice ribice commented Dec 21, 2024

Resolves #746

@ribice ribice requested a review from cleptric December 21, 2024 17:37
Copy link

codecov bot commented Dec 21, 2024

Codecov Report

Attention: Patch coverage is 67.64706% with 11 lines in your changes missing coverage. Please review.

Project coverage is 85.33%. Comparing base (c340089) to head (424fe5e).

Files with missing lines Patch % Lines
transport.go 62.50% 6 Missing ⚠️
hub.go 57.14% 2 Missing and 1 partial ⚠️
logrus/logrusentry.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #935      +/-   ##
==========================================
- Coverage   85.47%   85.33%   -0.15%     
==========================================
  Files          55       55              
  Lines        5486     5515      +29     
==========================================
+ Hits         4689     4706      +17     
- Misses        653      663      +10     
- Partials      144      146       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ribice ribice removed the request for review from cleptric December 21, 2024 18:11
@ribice ribice requested a review from cleptric December 22, 2024 09:06
@ribice
Copy link
Collaborator Author

ribice commented Dec 30, 2024

The only thing failing here is the coverage. Do I have to 'fix' it or we can merge as-is?

@cleptric
Copy link
Member

cleptric commented Jan 2, 2025

Do we have docs for this?

@ribice
Copy link
Collaborator Author

ribice commented Jan 6, 2025

Do we have docs for this?

No. Should I add it in sentry-docs?

@cleptric
Copy link
Member

cleptric commented Jan 7, 2025

Yes

@ribice
Copy link
Collaborator Author

ribice commented Jan 12, 2025

Co-authored-by: Michi Hoffmann <[email protected]>
@stephanie-anderson stephanie-anderson added Feature Issue type and removed Type: Feature labels Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Issue type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flush to receive go context type
4 participants