Skip to content

feat(quickpatch): Add parameter validation and prompting for missing arguments #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mwarkentin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(quickpatch): Add parameter validation and prompting for missing arguments #208

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions sentry_kube/cli/quickpatch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,12 @@ def quickpatch(
applies to production and sends a PR with the change.
"""

# TODO: Validate parameters
if not service:
raise click.UsageError("Missing required option '--service' / '-s'.")
if not resource:
raise click.UsageError("Missing required option '--resource' / '-r'.")
if not patch:
raise click.UsageError("Missing required option '--patch' / '-p'.")

if not no_pull:
git = Git(repo_path=str(workspace_root()))
Expand All @@ -71,13 +76,19 @@ def quickpatch(
git.fetch_origin()
git.merge_origin(git.default_branch)

get_arguments(service, patch)
required_args = get_arguments(service, patch)

# TODO: Validate all arguments are passed and prompt for the missing ones.
populated_arguments: MutableMapping[str, str] = {}
for arg in arguments:
key, value = arg.split("=", 2)
populated_arguments[key] = value

# Prompt for any required arguments that were not provided
for arg_name in required_args:
if arg_name not in populated_arguments:
populated_arguments[arg_name] = click.prompt(
f"Enter value for required argument '{arg_name}'"
)
apply_patch(
service,
ctx.obj.customer_name,
Expand Down