Skip to content

fix(vite): Fix environment variable loading issue for Windows #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2024
Merged

fix(vite): Fix environment variable loading issue for Windows #545

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0c1164
replace destructuring with object assignment
Rassilion Jun 6, 2024
81f3fe0
clean up
lforst Jun 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/bundler-plugin-core/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,11 @@ export function sentryUnpluginFactory({
);
// NOTE: Do not use the dotenv.config API directly to read the dotenv file! For some ungodly reason, it falls back to reading `${process.cwd()}/.env` which is absolutely not what we want.
const dotenvResult = dotenv.parse(dotenvFile);
process.env = { ...process.env, ...dotenvResult };

// Vite has a bug/behaviour where spreading into process.env will cause it to crash
// https://github.com/vitest-dev/vitest/issues/1870#issuecomment-1501140251
Object.assign(process.env, dotenvResult);

logger.info('Using environment variables configured in ".env.sentry-build-plugin".');
} catch (e: unknown) {
// Ignore "file not found" errors but throw all others
Expand Down
Loading