chore: Remove deprecated options and update changelog for v3 major#654
Merged
lforst merged 1 commit intogetsentry:mainfrom Jan 15, 2025
Merged
Conversation
timfish
force-pushed
the
timfish/chore/remove-deprecated
branch
from
62859b2 to
b968cf5
Compare
Yes! We don't need a deprecation I think. |
lforst
reviewed
Jan 14, 2025
Comment on lines
415
to
418
| name: "injectBuildInformation", | ||
| type: "boolean", | ||
| fullDescription: | ||
| "Options that are considered experimental and subject to change. This option does not follow semantic versioning and may change in any release.", | ||
| children: [ | ||
| { | ||
| name: "injectBuildInformation", | ||
| type: "boolean", | ||
| fullDescription: | ||
| "If set to true, the plugin will inject an additional `SENTRY_BUILD_INFO` variable. This contains information about the build, e.g. dependencies, node version and other useful data.\n\nDefaults to `false`.", | ||
| }, | ||
| ], | ||
| "If set to true, the plugin will inject an additional `SENTRY_BUILD_INFO` variable. This contains information about the build, e.g. dependencies, node version and other useful data.\n\nDefaults to `false`.", |
There was a problem hiding this comment.
I was just able to visualize this a bit better now that you changed it and realized that we should probably still leave injectBuildInformation in experimental state. Sorry for all the back and fourth!
Collaborator
Author
There was a problem hiding this comment.
No problem, just a quick revert!
timfish
force-pushed
the
timfish/chore/remove-deprecated
branch
from
eeb8a49 to
b968cf5
Compare
lforst
approved these changes
Jan 14, 2025
lforst
changed the title
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Jan 15, 2025
| datasource | package | from | to | | ---------- | ------------------- | ------ | ----- | | npm | @sentry/vite-plugin | 2.23.0 | 3.0.0 | ## [v3.0.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#300) ##### Breaking Changes - Injected code will now use `let`, which was added in ES6 (ES2015). This means that ES6 is the minimum JavaScript version that the Sentry bundler plugins support. - Deprecated options have been removed: - `deleteFilesAfterUpload` - Use `filesToDeleteAfterUpload` instead - `bundleSizeOptimizations.excludePerformanceMonitoring` - Use `bundleSizeOptimizations.excludeTracing` instead - `_experiments.moduleMetadata` - Use `moduleMetadata` instead - `cleanArtifacts` - Did not do anything ##### List of Changes - fix!: Wrap injected code in block-statement to contain scope ([#646](getsentry/sentry-javascript-bundler-plugins#646)) - chore!: Remove deprecated options ([#654](getsentry/sentry-javascript-bundler-plugins#654)) - feat(logger): Use console methods respective to log level ([#652](getsentry/sentry-javascript-bundler-plugins#652)) - fix(webpack): Ensure process exits when done ([#653](getsentry/sentry-javascript-bundler-plugins#653)) - fix: Use correct replacement matcher for `bundleSizeOptimizations.excludeTracing` ([#644](getsentry/sentry-javascript-bundler-plugins#644)) Work in this release contributed by [@jdelStrother](https://github.com/jdelStrother). Thank you for your contribution!
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Jan 15, 2025
| datasource | package | from | to | | ---------- | ------------------- | ------ | ----- | | npm | @sentry/vite-plugin | 2.23.0 | 3.0.0 | ## [v3.0.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#300) ##### Breaking Changes - Injected code will now use `let`, which was added in ES6 (ES2015). This means that ES6 is the minimum JavaScript version that the Sentry bundler plugins support. - Deprecated options have been removed: - `deleteFilesAfterUpload` - Use `filesToDeleteAfterUpload` instead - `bundleSizeOptimizations.excludePerformanceMonitoring` - Use `bundleSizeOptimizations.excludeTracing` instead - `_experiments.moduleMetadata` - Use `moduleMetadata` instead - `cleanArtifacts` - Did not do anything ##### List of Changes - fix!: Wrap injected code in block-statement to contain scope ([#646](getsentry/sentry-javascript-bundler-plugins#646)) - chore!: Remove deprecated options ([#654](getsentry/sentry-javascript-bundler-plugins#654)) - feat(logger): Use console methods respective to log level ([#652](getsentry/sentry-javascript-bundler-plugins#652)) - fix(webpack): Ensure process exits when done ([#653](getsentry/sentry-javascript-bundler-plugins#653)) - fix: Use correct replacement matcher for `bundleSizeOptimizations.excludeTracing` ([#644](getsentry/sentry-javascript-bundler-plugins#644)) Work in this release contributed by [@jdelStrother](https://github.com/jdelStrother). Thank you for your contribution!
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Jan 17, 2025
| datasource | package | from | to | | ---------- | ------------------- | ------ | ----- | | npm | @sentry/vite-plugin | 2.23.0 | 3.0.0 | ## [v3.0.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#300) ##### Breaking Changes - Injected code will now use `let`, which was added in ES6 (ES2015). This means that ES6 is the minimum JavaScript version that the Sentry bundler plugins support. - Deprecated options have been removed: - `deleteFilesAfterUpload` - Use `filesToDeleteAfterUpload` instead - `bundleSizeOptimizations.excludePerformanceMonitoring` - Use `bundleSizeOptimizations.excludeTracing` instead - `_experiments.moduleMetadata` - Use `moduleMetadata` instead - `cleanArtifacts` - Did not do anything ##### List of Changes - fix!: Wrap injected code in block-statement to contain scope ([#646](getsentry/sentry-javascript-bundler-plugins#646)) - chore!: Remove deprecated options ([#654](getsentry/sentry-javascript-bundler-plugins#654)) - feat(logger): Use console methods respective to log level ([#652](getsentry/sentry-javascript-bundler-plugins#652)) - fix(webpack): Ensure process exits when done ([#653](getsentry/sentry-javascript-bundler-plugins#653)) - fix: Use correct replacement matcher for `bundleSizeOptimizations.excludeTracing` ([#644](getsentry/sentry-javascript-bundler-plugins#644)) Work in this release contributed by [@jdelStrother](https://github.com/jdelStrother). Thank you for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do you want to remove
injectBuildInformationfrom_experimentstoo? It hasn't been deprecated yet 🤔