Skip to content

revert: Testing additional bundlers #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

revert: Testing additional bundlers #729

wants to merge 2 commits into from

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Apr 18, 2025

This PR reverts #725 because:

  • I broke the NODE_MAJOR_VERSION code and it was ending up as NaN due to the leading v
  • No tests were actually checking the rollup4 or vite6 output

Now I'm testing Vite 6 in this configuration, it does not work. It resolves rollup to rollup@3 whereas it needs rollup@4. I think we can only test these vastly different versions with multiple node_modules install directories and a different approach.

@timfish timfish requested review from lforst and Lms24 April 18, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lforst lforst lforst approved these changes

@Lms24 Lms24 Awaiting requested review from Lms24

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timfish @lforst