-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(flags/v8): Add Unleash integration #14948
base: v8
Are you sure you want to change the base?
Conversation
packages/browser/src/integrations/featureFlags/unleash/integration.ts
Outdated
Show resolved
Hide resolved
packages/browser/src/integrations/featureFlags/unleash/integration.ts
Outdated
Show resolved
Hide resolved
❌ 4 Tests Failed:
View the top 3 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, would you want to point that PR at develop and backport it to v8 maybe?
original: (this: UnleashClient, ...args: unknown[]) => unknown, | ||
): (this: UnleashClient, ...args: unknown[]) => unknown { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this affect typescript at all after we wrap it?
e.g. does your IDE still show the right types after we load this integration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Constructor (UnleashClientClass
) type was too general and raised lint though, pushing a commit
* const unleashIntegration = Sentry.unleashIntegration({unleashClientClass: UnleashClient}); | ||
* | ||
* Sentry.init({ | ||
* dsn: '___PUBLIC_DSN___', | ||
* integrations: [unleashIntegration], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe simplify this
* const unleashIntegration = Sentry.unleashIntegration({unleashClientClass: UnleashClient}); | |
* | |
* Sentry.init({ | |
* dsn: '___PUBLIC_DSN___', | |
* integrations: [unleashIntegration], | |
* Sentry.init({ | |
* dsn: '___PUBLIC_DSN___', | |
* integrations: [Sentry.unleashIntegration({unleashClientClass: UnleashClient})], |
Ref https://github.com/getsentry/team-replay/issues/514. Adds an integration for tracking Unleash flag evaluations, by patching the isEnabled method prototype.
Ref https://develop.sentry.dev/sdk/expected-features/#feature-flags